xz: Compile with PIC to fix linking errors #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't use |
|
This is simpler. The configure script has native support for it. |
|
We should probably drop assume ram as it breaks functionality over the board and dropping |
|
Unfortunately, I can't see any history into why assume-ram=4 was added. Maybe use on a 16MB device? Could increase to 64MB as that seems to be the new minimum. That's concerning that it breaks decompressing xz -9 archives though... |
While researching CircleCI build failures, I came across a linking error relating to liblzma, where ld instructs to recompile with fPIC. Unfortunately, this increases filesize. Added some configure flags to try to mitigate is somewhat. Removed maintainer as he is no longer active. Added PKG_CPE_ID for proper CVE tracking. Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
Added LTO. Funny enough, adding increases ipk size from 50491 to 50516. No idea why. |
|
|
jow-
pushed a commit
to lede-project/source
that referenced
this pull request
Apr 6, 2019
I made a similar change to this here: openwrt/packages#8159 However, it turns out this did not fix the problem as the problem has to do with tools/xz and not the xz package. The error is the same and causes linking errors as can be seen above. Signed-off-by: Rosen Penev <rosenp@gmail.com>
jollaman999
pushed a commit
to jollaman999/openwrt
that referenced
this pull request
Apr 9, 2019
I made a similar change to this here: openwrt/packages#8159 However, it turns out this did not fix the problem as the problem has to do with tools/xz and not the xz package. The error is the same and causes linking errors as can be seen above. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While researching CircleCI build failures, I came across a linking error
relating to liblzma, where ld instructs to recompile with fPIC.
Unfortunately, this increases filesize. Added some configure flags to try
to mitigate is somewhat.
Signed-off-by: Rosen Penev rosenp@gmail.com
Maintainer: nobody
Compile tested: ramips
Error: https://gist.github.com/neheb/9d3d0a2583e6e190e7254db078128640