unified expression about DaemonSet #1698
Conversation
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
|
@lilongfeng0902: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/assign @kadisi |
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
+ Coverage 51.75% 51.76% +0.01%
==========================================
Files 163 163
Lines 19716 19716
==========================================
+ Hits 10204 10206 +2
+ Misses 8542 8541 -1
+ Partials 970 969 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📢 Have feedback on the report? Share it here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilongfeng0902, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
…fix_calico * 'master' of https://github.com/openyurtio/openyurt: Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702) fix: add the logic of removing the finalizer (openyurtio#1695) Fix work dir nested `yurthub/yurthub` (openyurtio#1693) Add yurtappoverrider (openyurtio#1684) modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689) chore: slice loop replace (openyurtio#1690) unified expression about DaemonSet (openyurtio#1698) improve controller names (openyurtio#1687) add gateway public service controller (openyurtio#1685) feat: add token format checking to yurtadm join process (openyurtio#1681) add gateway internal service controller (openyurtio#1677) fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679) unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
What type of PR is this?
What this PR does / why we need it:
unified expression about DaemonSet, this way looking at the code won't show typos.
Which issue(s) this PR fixes:
Fixes #
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note