Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status info to YurtAppSet/YurtAppDaemon #1702

Merged
merged 48 commits into from
Sep 17, 2023
Merged

Add status info to YurtAppSet/YurtAppDaemon #1702

merged 48 commits into from
Sep 17, 2023

Conversation

vie-serendipity
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

After adding YurtAppOverrider, it is necessary to supplement status information to YurtAppSet/YurtAppDaemon.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

vie-serendipity and others added 27 commits August 24, 2023 09:21
@vie-serendipity
adjust CRD and add wildcard
bebc599
@vie-serendipity
add configuration of deployment webhook
a968b4a
@vie-serendipity
add register of webhook and controller
4544f78
@vie-serendipity
call deployment webhook directly
4e98daf
@vie-serendipity
remove flatternYaml and add more info
c69eb7e
@vie-serendipity
modify deployment webhook failurePolicy
15a5d09
@vie-serendipity
do some modifies
dd9c1f1
@vie-serendipity
rename missing configrender to overrider
286a0ff
@vie-serendipity
remove the outer of *
1f80a99
@vie-serendipity
pull origin master
5904bd9
@vie-serendipity
fix problems in the comments
a75de1f
@vie-serendipity
sync with master
0c5175e
@vie-serendipity
fix error in e2e of yurtappoverrider
c3f4156
@vie-serendipity
fix error in e2e of yurtappoverrider
4ab54bb
@vie-serendipity
fix error in validating webhook of yurtappoverrider
75e0f27
@vie-serendipity
add more UT
a2b58fa
@vie-serendipity
gci writting ut
bbb72d2
@vie-serendipity
fix error in ut
c1d8dbc
@vie-serendipity
add more UT
eb6b971
@vie-serendipity
supplement status
ad5a926
@vie-serendipity
supplement status of yurtappset
3fbce6c
@vie-serendipity
add status info to yurtappset/yurtappdaemon
eb2450b
feat: manifests
a3ea01e
@vie-serendipity
fix some problems
dc7cff7
@vie-serendipity
sync with master
bf08027
feat: refactor import
1f4ca9a
@vie-serendipity
Merge branch 'openyurtio:master' into supplement_status
209de32
@openyurt-bot
Copy link
Collaborator

@vie-serendipity: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

After adding YurtAppOverrider, it is necessary to supplement status information to YurtAppSet/YurtAppDaemon.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added kind/enhancement kind/enhancement size/L size/L: 100-499 labels Sep 14, 2023
@vie-serendipity vie-serendipity mentioned this pull request Sep 16, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, vie-serendipity

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 17, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 17, 2023
@openyurt-bot openyurt-bot merged commit f782021 into openyurtio:master Sep 17, 2023
13 of 14 checks passed
@rambohe-ch
Copy link
Member

Fixes #1703

@open-digger-bot open-digger-bot bot mentioned this pull request Sep 20, 2023
Closed
luckymrwang added a commit to luckymrwang/openyurt that referenced this pull request Sep 20, 2023
@luckymrwang
Merge branch 'master' of https://github.com/openyurtio/openyurt into …
8d54d5a 
…fix_calico

* 'master' of https://github.com/openyurtio/openyurt:
  Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702)
  fix: add the logic of removing the finalizer (openyurtio#1695)
  Fix work dir nested `yurthub/yurthub` (openyurtio#1693)
  Add yurtappoverrider (openyurtio#1684)
  modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689)
  chore: slice loop replace (openyurtio#1690)
  unified expression about DaemonSet (openyurtio#1698)
  improve controller names (openyurtio#1687)
  add gateway public service controller (openyurtio#1685)
  feat: add token format checking to yurtadm join process (openyurtio#1681)
  add gateway internal service controller (openyurtio#1677)
  fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679)
  unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/L size/L: 100-499
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vie-serendipity @openyurt-bot @rambohe-ch