Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

README points to 404 #5

Open
ecp4224 opened this issue Oct 26, 2018 · 1 comment
Open

README points to 404 #5

ecp4224 opened this issue Oct 26, 2018 · 1 comment

Comments

@ecp4224
Copy link

ecp4224 commented Oct 26, 2018

The Token Vesting contract link points to a missing page

@zachlysobey
Copy link

I was about to fix the link, but it wasn't as straight-forward as I'd hoped.

openzepplin-solidity@master currently has this file in contracts/drafts

But... this project depends on a version of oz-solidity which is over a year old. Moreover, its not a published version or tag -- its pointing at a git commit hash.

"zeppelin-solidity": "git+https://git@github.com/OpenZeppelin/zeppelin-solidity.git#8e01dd14f9211239213ae7bd4c6af92dd18d4ab7"

https://github.com/OpenZeppelin/token-vesting-ui/blob/master/package.json#L21
https://github.com/OpenZeppelin/openzeppelin-solidity/tree/8e01dd14f9211239213ae7bd4c6af92dd18d4ab7

I guess it might be sensible to just update the link to point to the file at that commit hash, but once that dependency gets updated, it will likely become incorrect again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants