Skip to content

Commit

Permalink
update max_variance limit in zdb_block_size_histogram test for CI
Browse files Browse the repository at this point in the history
Commit 2d78434 had previously
updated this hardcoded limit to allow for CI testing. As there
is no deterministic pass/fail value, the need has arisen for
one more small increase.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Edmund Nadolski <edmund.nadolski@ixsystems.com>
Closes #15252
  • Loading branch information
ednadolski-ix committed Sep 9, 2023
1 parent 5cc1876 commit 0ee9b02
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,11 @@ function histo_check_test_pool
# 4096 blocksize count for asize. For verification we stick
# to just lsize counts.
#
# The max_variance is hard-coded here at 12% to leave us some
# margin. Testing has shown this normally to be in the range
# of 2%-8%, but it may be as large as 11%.
# Variances are expected since this test does not account for
# metadata. The hardcoded limit here is empirical and should
# not be construed as deterministic.
###################
let max_variance=12
let max_variance=15
let fail_value=0
let error_count=0
log_note "Comparisons for ${pool}"
Expand Down

0 comments on commit 0ee9b02

Please sign in to comment.