Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile #100

Closed
Rudd-O opened this issue Feb 15, 2011 · 17 comments
Closed

Does not compile #100

Rudd-O opened this issue Feb 15, 2011 · 17 comments

Comments

@Rudd-O
Copy link
Contributor

Rudd-O commented Feb 15, 2011

make[3]: Entering directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd/zinject'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd/zinject'
Making all in ztest
make[3]: Entering directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd/ztest'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd/ztest'
Making all in zpios
make[3]: Entering directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd/zpios'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd/zpios'
make[3]: Entering directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd'
make[2]: Leaving directory `/home/rudd-o/Projects/Third-party/kernelzfs/cmd'
Making all in module
make[2]: Entering directory `/home/rudd-o/Projects/Third-party/kernelzfs/module'
make -C /home/rudd-o/Projects/Third-party/linux/source SUBDIRS=`pwd`  modules
make[3]: Entering directory `/home/rudd-o/Projects/Third-party/linux/source'
  CC [M]  /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.o
In file included from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_fuid.h:33:0,
                 from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_acl.h:34,
                 from /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.c:30:
/home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_vfsops.h:45:2: error: expected specifier-qualifier-list before ‘vfs_t’
In file included from /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.c:32:0:
/home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_znode.h:317:27: error: expected ‘)’ before ‘*’ token
make[5]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.o] Error 1
make[4]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon] Error 2
make[3]: *** [_module_/home/rudd-o/Projects/Third-party/kernelzfs/module] Error 2
make[3]: Leaving directory `/home/rudd-o/Projects/Third-party/linux/source'
make[2]: *** [modules] Error 2
make[2]: Leaving directory `/home/rudd-o/Projects/Third-party/kernelzfs/module'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/rudd-o/Projects/Third-party/kernelzfs'
make: *** [all] Error 2

Latest checkouts of spl master and zfs master. Does not compile. Fedora 14, self-compiled kernel:
Linux karen.dragonfear 2.6.37karen.dragonfear #1 SMP Sat Jan 8 11:39:13 PST 2011 x86_64 x86_64 x86_64 GNU/Linux

****ing compilers, how do they work? :-)

Let me know when this is fixed so I can re-compile again.

@behlendorf
Copy link
Contributor

I suspect this is accidental breakage from updating the SPL to drop the vfs_t type for the zpl work. For the moment you can either just use the 0.5.2 version of the SPL which doesn't contain this change or you can use the master spl branch and the zpl zfs branch (2.6.32-2.6.36 based kernels for the moment).

Sorry about that!

@behlendorf
Copy link
Contributor

Closing, this is fixed in the 0.6.0-rc1 release candidate.

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

Thanks Brian!

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

make[3]: Entering directory `/home/rudd-o/Projects/Third-party/linux/source'
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/avl/../../module/avl/avl.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/../../module/unicode/u8_textprep.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/avl/zavl.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_deleg.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair_alloc_spl.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair_alloc_fixed.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/znvpair.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/arc.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/../../module/unicode/uconv.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zprop_common.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_namecheck.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/zunicode.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zpios/../../module/zpios/pios.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_comutil.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/bplist.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_fletcher.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/bpobj.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zpios/zpios.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dbuf.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_uio.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/ddt.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zpool_prop.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/ddt_zap.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/zcommon.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_diff.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_object.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_objset.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_send.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_traverse.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_tx.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_zfetch.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dnode.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dnode_sync.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_dataset.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_deadlist.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_deleg.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_dir.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_pool.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.o
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c: In function ‘dsl_prop_predict_sync’:
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c:379:2: warning: case value ‘33’ not in enumerated type ‘zprop_source_t’
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c: In function ‘dsl_prop_set_sync’:
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c:656:2: warning: case value ‘33’ not in enumerated type ‘zprop_source_t’
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c:644:2: warning: case value ‘41’ not in enumerated type ‘zprop_source_t’
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_scan.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_synctask.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/fm.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/gzip.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/lzjb.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/metaslab.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/refcount.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/rrwlock.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/sa.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/sha256.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_boot.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_config.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_errlog.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_history.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_misc.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/space_map.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/txg.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/uberblock.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/unique.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_cache.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_file.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_label.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_mirror.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_missing.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_queue.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_raidz.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_root.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zap.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zap_leaf.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zap_micro.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_acl.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_byteswap.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_debug.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_dir.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_fm.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_fuid.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_ioctl.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_log.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_onexit.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_replay.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_rlock.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_sa.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_vfsops.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_vnops.o
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_vfsops.c: In function ‘zfsvfs_teardown’:
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/zfs_vfsops.c:1083:3: error: implicit declaration of function ‘invalidate_inodes’

Did you compile before tagging, dude?

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

With kernel 2.6.38-rc7:

make -C /home/rudd-o/Projects/Third-party/linux/source O=/home/rudd-o/Projects/Third-party/linux/build/karen.dragonfear/. modules
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/avl/../../module/avl/avl.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/avl/zavl.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair_alloc_spl.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair_alloc_fixed.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/znvpair.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/../../module/unicode/u8_textprep.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/../../module/unicode/uconv.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/zunicode.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_deleg.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zprop_common.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_namecheck.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_comutil.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_fletcher.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_uio.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zpool_prop.o
LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/zcommon.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/arc.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/bplist.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/bpobj.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dbuf.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/ddt.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/ddt_zap.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_diff.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_object.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_objset.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_send.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_traverse.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_tx.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_zfetch.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dnode.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dnode_sync.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_dataset.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_deadlist.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_deleg.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_dir.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_pool.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.o
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c: In function ‘dsl_prop_predict_sync’:
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c:379:2: warning: case value ‘33’ not in enumerated type ‘zprop_source_t’
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c: In function ‘dsl_prop_set_sync’:
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c:656:2: warning: case value ‘33’ not in enumerated type ‘zprop_source_t’
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_prop.c:644:2: warning: case value ‘41’ not in enumerated type ‘zprop_source_t’
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_scan.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dsl_synctask.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/fm.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/gzip.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/lzjb.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/metaslab.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/refcount.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/rrwlock.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/sa.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/sha256.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_boot.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_config.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_errlog.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_history.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/spa_misc.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/space_map.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/txg.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/uberblock.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/unique.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_cache.o
CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.o
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.c: In function ‘vdev_disk_open’:
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.c:176:2: error: implicit declaration of function ‘open_bdev_excl’
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.c:176:7: warning: assignment makes pointer from integer without a cast
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.c: In function ‘vdev_disk_close’:
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.c:225:3: error: implicit declaration of function ‘close_bdev_excl’
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.c: In function ‘vdev_disk_read_rootlabel’:
/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.c:698:7: warning: assignment makes pointer from integer without a cast
make[7]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/vdev_disk.o] Error 1
make[6]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs] Error 2
make[5]: *** [module/home/rudd-o/Projects/Third-party/kernelzfs/module] Error 2
make[4]: *** [sub-make] Error 2
make[3]: *** [all] Error 2
make[3]: Leaving directory /home/rudd-o/Projects/Third-party/linux/build/karen.dragonfear' make[2]: *** [modules] Error 2 make[2]: Leaving directory/home/rudd-o/Projects/Third-party/kernelzfs/module'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/rudd-o/Projects/Third-party/kernelzfs'

@behlendorf
Copy link
Contributor

The particular build issue you hit was fixed in the 0.6.0-rc1 tag, the next couple issues are fixed in the spl and zfs master changes but aren't part of a tag yet. I hope to create an 0.6.0-rc2 tag this week after wrapping up a few other fixes. In the meanwhile just grab the master branches.

git clone git://github.com/behlendorf/spl.git
git clone git://github.com/behlendorf/zfs.git

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

commit 5075c7e

make[3]: Entering directory /home/rudd-o/Projects/Third-party/linux/build/karen.dragonfear' make -C /home/rudd-o/Projects/Third-party/linux/source O=/home/rudd-o/Projects/Third-party/linux/build/karen.dragonfear/. modules CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/avl/../../module/avl/avl.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/../../module/unicode/u8_textprep.o LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/avl/zavl.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair_alloc_spl.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/../../module/nvpair/nvpair_alloc_fixed.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/../../module/unicode/uconv.o LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/nvpair/znvpair.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_deleg.o LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/unicode/zunicode.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zpios/../../module/zpios/pios.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.o In file included from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_acl.h:31:0, from /home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.c:30: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:49:16: error: redefinition of ‘struct xoptattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:146:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:67:3: error: conflicting types for ‘xoptattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:160:3: note: previous declaration of ‘xoptattr_t’ was here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:133:16: error: redefinition of ‘struct xvattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:162:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:141:3: error: conflicting types for ‘xvattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:170:3: note: previous declaration of ‘xvattr_t’ was here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h: In function ‘xva_init’: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:280:28: error: ‘ATTR_XVATTR’ undeclared (first use in this function) /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:280:28: note: each undeclared identifier is reported only once for each function it appears in /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h: At top level: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:303:0: warning: "V_ACE_MASK" redefined /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:97:0: note: this is the location of the previous definition /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:304:0: warning: "V_APPEND" redefined /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:98:0: note: this is the location of the previous definition /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:310:16: error: redefinition of ‘struct vsecattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:172:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:318:3: error: conflicting types for ‘vsecattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:180:3: note: previous declaration of ‘vsecattr_t’ was here make[7]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon/../../module/zcommon/zfs_prop.o] Error 1 make[6]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zcommon] Error 2 make[6]: *** Waiting for unfinished jobs.... CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/arc.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/bplist.o LD [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zpios/zpios.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/bpobj.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dbuf.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/ddt.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/ddt_zap.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_diff.o CC [M] /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_object.o In file included from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_acl.h:31:0, from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_sa.h:33, from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_znode.h:37, from /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_diff.c:40: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:49:16: error: redefinition of ‘struct xoptattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:146:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:67:3: error: conflicting types for ‘xoptattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:160:3: note: previous declaration of ‘xoptattr_t’ was here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:133:16: error: redefinition of ‘struct xvattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:162:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:141:3: error: conflicting types for ‘xvattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:170:3: note: previous declaration of ‘xvattr_t’ was here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h: In function ‘xva_init’: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:280:28: error: ‘ATTR_XVATTR’ undeclared (first use in this function) /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:280:28: note: each undeclared identifier is reported only once for each function it appears in /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h: At top level: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:303:0: warning: "V_ACE_MASK" redefined /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:97:0: note: this is the location of the previous definition /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:304:0: warning: "V_APPEND" redefined /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:98:0: note: this is the location of the previous definition /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:310:16: error: redefinition of ‘struct vsecattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:172:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:318:3: error: conflicting types for ‘vsecattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:180:3: note: previous declaration of ‘vsecattr_t’ was here In file included from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_acl.h:31:0, from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_sa.h:33, from /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/zfs_znode.h:37, from /home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu.c:45: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:49:16: error: redefinition of ‘struct xoptattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:146:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:67:3: error: conflicting types for ‘xoptattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:160:3: note: previous declaration of ‘xoptattr_t’ was here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:133:16: error: redefinition of ‘struct xvattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:162:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:141:3: error: conflicting types for ‘xvattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:170:3: note: previous declaration of ‘xvattr_t’ was here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h: In function ‘xva_init’: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:280:28: error: ‘ATTR_XVATTR’ undeclared (first use in this function) /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:280:28: note: each undeclared identifier is reported only once for each function it appears in /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h: At top level: /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:303:0: warning: "V_ACE_MASK" redefined /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:97:0: note: this is the location of the previous definition /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:304:0: warning: "V_APPEND" redefined /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:98:0: note: this is the location of the previous definition /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:310:16: error: redefinition of ‘struct vsecattr’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:172:16: note: originally defined here /home/rudd-o/Projects/Third-party/kernelzfs/include/sys/xvattr.h:318:3: error: conflicting types for ‘vsecattr_t’ /home/rudd-o/Projects/Third-party/spl/include/sys/vnode.h:180:3: note: previous declaration of ‘vsecattr_t’ was here make[7]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu_diff.o] Error 1 make[7]: *** Waiting for unfinished jobs.... make[7]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs/../../module/zfs/dmu.o] Error 1 make[6]: *** [/home/rudd-o/Projects/Third-party/kernelzfs/module/zfs] Error 2 make[5]: *** [_module_/home/rudd-o/Projects/Third-party/kernelzfs/module] Error 2 make[4]: *** [sub-make] Error 2 make[3]: *** [all] Error 2 make[3]: Leaving directory/home/rudd-o/Projects/Third-party/linux/build/karen.dragonfear'
make[2]: *** [modules] Error 2
make[2]: Leaving directory /home/rudd-o/Projects/Third-party/kernelzfs/module' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory/home/rudd-o/Projects/Third-party/kernelzfs'
make: *** [all] Error 2

~/Projects/Third-party/kernelzfs@karen.dragonfear α:
uname -a
Linux karen.dragonfear 2.6.38-rc7karen.dragonfear #1 SMP Mon Mar 7 08:06:46 PST 2011 x86_64 x86_64 x86_64 GNU/Linux

@behlendorf
Copy link
Contributor

You need to update the zfs AND spl code. It looks like you've just updated the zfs code. Commit 47995fa in the SPL code drops these symbols which are conflicting.

@behlendorf
Copy link
Contributor

My bad! These changes were still on the xvattr branch I didn't get them merged in. I just took care it, sorry about that. Master is now up to date.

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

I am pulling from:

~/Projects/Third-party/kernelzfs@karen.dragonfear α:
git remote show origin

  • remote origin
    Fetch URL: https://github.com/behlendorf/zfs.git
    Push URL: https://github.com/behlendorf/zfs.git
    HEAD branch: master
    Remote branches:
    gh-pages tracked
    master tracked
    refs/remotes/origin/zpl stale (use 'git remote prune' to remove)
    top tracked
    Local branch configured for 'git pull':
    master merges with remote master
    Local ref configured for 'git push':
    master pushes to master (up to date)

And that is what I am configuring and making. And nothing came in when I did git pull just right now. Also there is no xvattr branch either. Just master.

What am I doing wrong?

@behlendorf
Copy link
Contributor

The fix was on the spl side, make sure you pull the latest spl sources. It looks like you were pulling the latest zfs sources. I try to version the spl and zfs because sometimes they need to move in lockstep. I just grabbed fresh copies of both the spl+zfs master sources and built them on ubuntu natty (2.6.38-rc5). If I were you I'd start fresh. :)

rm -Rf spl zfs
git clone git://github.com/behlendorf/spl.git
git clone git://github.com/behlendorf/zfs.git
cd spl
./configure && make -s
cd ../zfs
./configure && make -s

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

aw shux I have been doing stupid shite on my side, disregard that!

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

don't work either:

checking kernel source directory... /home/rudd-o/Projects/Third-party/linux/source
checking kernel build directory... /home/rudd-o/Projects/Third-party/linux/build/karen.dragonfear
checking kernel source version... 2.6.38-rc7karen.dragonfear
checking kernel file name for module symbols... Module.symvers
checking spl source directory... ../spl/module
checking spl build directory... ../spl/module
checking spl source version... Not found
configure: error:
*** Cannot determine the version of the spl source.
*** Please prepare the spl source before running this script

this after configuring and making the spl source. lemme try installing it.

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

compiled and installed. now to test.

@behlendorf
Copy link
Contributor

Or add with --with-spl option. The build system makes a couple guesses as to where you left the spl source (/usr/src/spl, ../spl) and if it can't find it you need to either manually specify where you left it. Installing the devel package should make sure it ends up in /usr/src/spl so it'll be OK.

@behlendorf
Copy link
Contributor

Rudd-O: If it's not to much trouble would you mind pulling the 'mount' branch from zfs instead and kicking the tires there instead. It addresses a few issues people have observed regarding mount/umount and I'd like it to see a little more testing before merging in to master.

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Mar 7, 2011

Sure! Doing that as we speak.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants