Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what should zfs clone -o canmount=noauto do? #2241

Closed
jcflack opened this issue Apr 6, 2014 · 6 comments
Closed

what should zfs clone -o canmount=noauto do? #2241

jcflack opened this issue Apr 6, 2014 · 6 comments
Milestone

Comments

@jcflack
Copy link

jcflack commented Apr 6, 2014

What the manpage says about is "When the noauto option is set, a dataset can only be mounted and unmounted explicitly. The dataset is not mounted automatically when the dataset is created or imported ...."

And yet, when cloned, it is....

I've just tried on a genuine Solaris 10 machine too with the same result, so it is upstream and not ZoL-only (I have a github account so it's easier to report here).
As described,

zfs create -o canmount=noauto tank/testfs

creates the dataset and doesn't mount it. But

zfs clone -o canmount=noauto tank/users@today tank/users_today

creates the clone and mounts it at the default location before you have any chance to intervene.

@behlendorf behlendorf added this to the 0.7.0 milestone Apr 7, 2014
@behlendorf behlendorf added the Bug label Apr 7, 2014
@behlendorf
Copy link
Contributor

That sure sounds like a bug to me, thanks for reporting it.

FransUrbo added a commit to FransUrbo/zfs that referenced this issue Jun 6, 2014
uqs pushed a commit to freebsd/freebsd-src that referenced this issue Jun 12, 2015
Creation of a new filesystem does not imply an intent to mount it.

Since canmount property is not inherited and its default value is 'on',
the only scenario where this matters is zfs clone -o canmount=noauto.
zfs create -o canmount=noauto already does not mount the new filesystem.

Also see:
https://www.illumos.org/issues/5984
https://reviews.csiden.org/r/228/
FransUrbo/zfs@dd0e0e6
openzfs/zfs#2241

Reviewed by:	mahrens
MFC after:	8 days
Sponsored by:	ClusterHQ


git-svn-id: svn+ssh://svn.freebsd.org/base/head@284309 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
uqs pushed a commit to freebsd/freebsd-src that referenced this issue Jun 12, 2015
Creation of a new filesystem does not imply an intent to mount it.

Since canmount property is not inherited and its default value is 'on',
the only scenario where this matters is zfs clone -o canmount=noauto.
zfs create -o canmount=noauto already does not mount the new filesystem.

Also see:
https://www.illumos.org/issues/5984
https://reviews.csiden.org/r/228/
FransUrbo/zfs@dd0e0e6
openzfs/zfs#2241

Reviewed by:	mahrens
MFC after:	8 days
Sponsored by:	ClusterHQ
brooksdavis pushed a commit to CTSRD-CHERI/cheribsd that referenced this issue Jul 23, 2015
Creation of a new filesystem does not imply an intent to mount it.

Since canmount property is not inherited and its default value is 'on',
the only scenario where this matters is zfs clone -o canmount=noauto.
zfs create -o canmount=noauto already does not mount the new filesystem.

Also see:
https://www.illumos.org/issues/5984
https://reviews.csiden.org/r/228/
FransUrbo/zfs@dd0e0e6
openzfs/zfs#2241

Reviewed by:	mahrens
MFC after:	8 days
Sponsored by:	ClusterHQ
@kernelOfTruth
Copy link
Contributor

https://www.illumos.org/issues/5984 zfs clone should not mount the clone if canmount == noauto

illumos/illumos-gate@780828c

@gmelikov
Copy link
Member

gmelikov commented Jan 8, 2017

@behlendorf this PR makes https://www.illumos.org/issues/5984 already applied, but it's not in OpenZFS Tracking.

@gmelikov
Copy link
Member

gmelikov commented Jan 8, 2017

@jumbi77 yes, it's exactly what i meant.

@gmelikov
Copy link
Member

gmelikov commented Jan 8, 2017

I thought that it was autogenerated. Because it wasn't, I have updated the OpenZFS Tracking page.

@behlendorf
Copy link
Contributor

@gmelikov I'd love for it to be auto-generated but currently it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants