Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RHEL5 ZVOLs #43

Closed
behlendorf opened this issue Aug 4, 2010 · 1 comment
Closed

Fix RHEL5 ZVOLs #43

behlendorf opened this issue Aug 4, 2010 · 1 comment

Comments

@behlendorf
Copy link
Contributor

After the recent batch of ZVOL fixes I seem to have accidentally broken minor devices for RHEL5 (2.6.18). Everything works fine for RHEL6 (2.6.32) so I hadn't noticed. Anyway, I suspect this is related to adding zvol back in to the /dev/ path but it needs to be run down.

Unable to handle kernel NULL pointer dereference at 0000000000000010 RIP:
 [] create_dir+0x1d/0x1dc
<8>PGD c45a2067 PUD c5638067 PMD 0
Oops: 0000 [1] SMP
last sysfs file: /class/misc/zfs/dev
<8>Pid: 9379, comm: lt-zfs Tainted: P      2.6.18-prep #1
<8>RIP: 0010:[]  [] create_dir+0x1d/0x1dc
<8>RSP: 0018:ffff81006392fca8  EFLAGS: 00010292
<8>RAX: ffff81005eec9870 RBX: ffff81007ff61538 RCX: ffff81006392fcf8
<8>RDX: ffff81007ff61538 RSI: 0000000000000000 RDI: ffff81007ff61530
<8>RBP: ffff81006392fcd8 R08: ffffffff8033c9e8 R09: 000000000000003e
<8>R10: ffffffff804075a0 R11: 0000000000000000 R12: ffff81007ff61530
<8>R13: ffff81007ff61530 R14: ffff81006392fcf8 R15: 0000000000000000
<8>FS:  00002b69974c9c00(0000) GS:ffffffff803da000(0000) knlGS:0000000000000000
<8>CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
<8>CR2: 0000000000000010 CR3: 00000000cd03c000 CR4: 00000000000006e0
<8>Process lt-zfs (pid: 9379, threadinfo ffff81006392e000, task ffff81007e0257e0)
<8>Stack:  0000000000000000 ffff81007ff61530 ffff81007ff61340 ffff81007ff61530
<8> ffff81005eec9a00 0000000000000000 ffff81006392fd08 ffffffff80118282
<8> ffff81006392fd08 ffffffff8005a929 0000000000000000 ffff81007ff61530
<8>Call Trace:
<8> [] sysfs_create_dir+0x5a/0x78
<8> [] kobject_get+0x1a/0x21
<8> [] kobject_add+0xe7/0x1ac
<8> [] blk_register_queue+0x3f/0x86
<8> [] add_disk+0x44/0x48
<8> [] :zfs:__zvol_create_minor+0x510/0x59b
<8> [] __vmalloc_node+0x56/0x63
<8> [] :zfs:zvol_create_minor+0x64/0x98
<8> [] :zfs:zfs_ioc_create_minor+0xc/0xe
<8> [] :zfs:zfs_ioctl+0x122/0x18d
<8> [] do_ioctl+0x2a/0x77
<8> [] vfs_ioctl+0x450/0x4b1
<8> [] audit_syscall_entry+0x18b/0x1c1
<8> [] sys_ioctl+0x5f/0x82
<8> [] tracesys+0xd5/0xe0
<8>
<8>
<8>Code: 48 8b 7e 10 48 81 c7 b8 00 00 00 e8 a4 ee f4 ff fc 31 c0 48
RIP  [] create_dir+0x1d/0x1dc
<8> RSP 
CR2: 0000000000000010
@behlendorf
Copy link
Contributor Author

Fixed by commits:
5ce3b77
dfc166d
dd11e3f

This unfortunately means we need to drop the /zvol/ component from the /dev/ path again. However, that change luckily never made it in to a real tag so no harm done. Also we must impose a rather harsh path name limit on older kernels to avoid a NULL deref. Both of these concerns are not issues for modern kernels and can be relaxed if we drop support for RHEL5.

@dswartz dswartz mentioned this issue Apr 22, 2015
Closed
akatrevorjay added a commit to akatrevorjay/zfs that referenced this issue Dec 16, 2017
@akatrevorjay
# This is a combination of 56 commits.
4ae6a0d 
# This is the 1st commit message:
Merge branch 'master' of https://github.com/zfsonlinux/zfs

* 'master' of https://github.com/zfsonlinux/zfs:
  Enable QAT support in zfs-dkms RPM

# This is the commit message openzfs#2:

Import 0.6.5.7-0ubuntu3

# This is the commit message openzfs#3:

gbp changes

# This is the commit message openzfs#4:

Bump ver

# This is the commit message openzfs#5:

-j9 baby

# This is the commit message openzfs#6:

Up

# This is the commit message openzfs#7:

Yup

# This is the commit message openzfs#8:

Add new module

# This is the commit message openzfs#9:

Up

# This is the commit message openzfs#10:

Up

# This is the commit message openzfs#11:

Bump

# This is the commit message openzfs#12:

Grr

# This is the commit message openzfs#13:

Yay

# This is the commit message openzfs#14:

Yay

# This is the commit message openzfs#15:

Yay

# This is the commit message openzfs#16:

Yay

# This is the commit message openzfs#17:

Yay

# This is the commit message openzfs#18:

Yay

# This is the commit message openzfs#19:

yay

# This is the commit message openzfs#20:

yay

# This is the commit message openzfs#21:

yay

# This is the commit message openzfs#22:

Update ppa script

# This is the commit message openzfs#23:

Update gbp conf with br changes

# This is the commit message openzfs#24:

Update gbp conf with br changes

# This is the commit message openzfs#25:

Bump

# This is the commit message openzfs#26:

No pristine

# This is the commit message openzfs#27:

Bump

# This is the commit message openzfs#28:

Lol whoops

# This is the commit message openzfs#29:

Fix name

# This is the commit message openzfs#30:

Fix name

# This is the commit message openzfs#31:

rebase

# This is the commit message openzfs#32:

Bump

# This is the commit message openzfs#33:

Bump

# This is the commit message openzfs#34:

Bump

# This is the commit message openzfs#35:

Bump

# This is the commit message openzfs#36:

ntrim

# This is the commit message openzfs#37:

Bump

# This is the commit message openzfs#38:

9

# This is the commit message openzfs#39:

Bump

# This is the commit message openzfs#40:

Bump

# This is the commit message openzfs#41:

Bump

# This is the commit message openzfs#42:

Revert "9"

This reverts commit de488f1.

# This is the commit message openzfs#43:

Bump

# This is the commit message openzfs#44:

Account for zconfig.sh being removed

# This is the commit message openzfs#45:

Bump

# This is the commit message openzfs#46:

Add artful

# This is the commit message openzfs#47:

Add in zed.d and zpool.d scripts

# This is the commit message openzfs#48:

Bump

# This is the commit message openzfs#49:

Bump

# This is the commit message openzfs#50:

Bump

# This is the commit message openzfs#51:

Bump

# This is the commit message openzfs#52:

ugh

# This is the commit message openzfs#53:

fix zed upgrade

# This is the commit message openzfs#54:

Bump

# This is the commit message openzfs#55:

conf file zed.d

# This is the commit message #56:

Bump
richardelling pushed a commit to richardelling/zfs that referenced this issue Oct 15, 2018
@vishnuitta
pool/volume create/import/destroy for uzfs (openzfs#43)
5540385 
* pool/volume create/import/destroy/export for uzfs
* testcase to do IOs on imported pools
* CLI tests for target IP address
* owning dataset in uZFS during handshake with target

Signed-off-by: Vishnu Itta <vitta@mayadata.io>
shartse pushed a commit to shartse/zfs that referenced this issue May 15, 2019
@sdimitro @ahrens
Log Spacemap (openzfs#43)
b06927c 
Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com>
@green-apple-ok green-apple-ok mentioned this issue Mar 23, 2021
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behlendorf