Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Linux-Maximum to 5.8 #11019

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

ndanyluk
Copy link

@ndanyluk ndanyluk commented Oct 7, 2020

Bump max kernel version to 5.8 to match the supported releases indicated in the release notes

Motivation and Context

Release 0.8.5 included fixes/commits targeting 5.8/5.9 compatibility. The release notes indicate support for kernels up to 5.8 but the META file still indicates 5.6.

This was first raised in one of the comments in the proposed 0.8.5 patch set

Description

I modified the META file to allow packages to be built for 5.7-5.8 kernels.

How Has This Been Tested?

I have only tested by building DKMS .deb packages on Ubuntu 20.04 (arm64, kernel 5.7 & 5.8 installed)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Bump max kernel version to 5.8 to match the supported releases
indicated in the release notes of 0.8.5

Signed-off-by: Nick Danyluk <ndanyluk7@gmail.com>
@PrivatePuffin
Copy link
Contributor

LGTM
That being said, are you sure this is still tested-to-be-working on 2.6.32?

@ndanyluk
Copy link
Author

ndanyluk commented Oct 7, 2020

@Ornias1993 to be honest, I'm not sure. I only tested the 5.7/5.8 kernels on my system. Do the buildbots cover 2.6.32?

This is my first OpenZFS PR, so I'd like to not break anything 😂

@PrivatePuffin
Copy link
Contributor

@Ornias1993 to be honest, I'm not sure. I only tested the 5.7/5.8 kernels on my system. Do the buildbots cover 2.6.32?

They don't, thats why I'm a bit hessitant to call 2.6.32 supported, personally.

This is my first OpenZFS PR, so I'd like to not break anything 😂

Don't worry about it, your PR is perfectly fine :)

@tonyhutter
Copy link
Contributor

@ndanyluk thanks for this fix - I overlooked updating it for the 0.8.5 release. Can you please make your PR against the zfs-0.8.6-staging branch instead of zfs-0.8-release though? You should just be able to change the base branch in the drop down menu in github at the top of this PR.

@Ornias1993 we actually do support the 2.6.32 kernel for the 0.8.x release (since we support Centos 6), but we don't support it for master. Centos 6 does go end of life in November though so I expect we'll drop ZFS support for it then.

@PrivatePuffin
Copy link
Contributor

PrivatePuffin commented Oct 7, 2020

@Ornias1993 we actually do support the 2.6.32 kernel for the 0.8.x release (since we support Centos 6), but we don't support it for master. Centos 6 does go end of life in November though so I expect we'll drop ZFS support for it then.

I've been an idiot, Yes 2.6.32 is still automatically tested on 0.8.x
Sorry...

@tonyhutter tonyhutter mentioned this pull request Oct 7, 2020
12 tasks
@ndanyluk ndanyluk changed the base branch from zfs-0.8-release to zfs-0.8.6-staging October 7, 2020 20:56
@ndanyluk
Copy link
Author

ndanyluk commented Oct 7, 2020

@ndanyluk thanks for this fix - I overlooked updating it for the 0.8.5 release. Can you please make your PR against the zfs-0.8.6-staging branch instead of zfs-0.8-release though? You should just be able to change the base branch in the drop down menu in github at the top of this PR.

No problem, happy to help! I just changed the base branch to 0.8.6 I think.

@PrivatePuffin
Copy link
Contributor

I just changed the base branch to 0.8.6 I think.

Worked out pretty fine, don't worry about those test failures. Not your fault :)

@tonyhutter tonyhutter merged commit ad69652 into openzfs:zfs-0.8.6-staging Oct 7, 2020
@ndanyluk ndanyluk deleted the zfs-0.8-release branch October 8, 2020 04:27
@gdevenyi
Copy link
Contributor

Perhaps this is a place where a rare 0.8.5.1 would be appropriate to get out quickly with this single fix?

@behlendorf
Copy link
Contributor

@gdevenyi the value in the META file is only informational. So while it may be a little misleading it won't cause any build issues. The 0.8.5 tag as is will build and work with the now released 5.9 kernel. I've gone ahead and updated the release notes to make it clear it's compatible.

@ndanyluk
Copy link
Author

ndanyluk commented Oct 14, 2020

@gdevenyi the value in the META file is only informational. So while it may be a little misleading it won't cause any build issues. The 0.8.5 tag as is will build and work with the now released 5.9 kernel. I've gone ahead and updated the release notes to make it clear it's compatible.

@behlendorf Is the value only informational? When I built DKMS packages on Ubuntu 20.04 I had to update META to include kernel 5.8 or my packages wouldn't build (at least if memory serves).

@PrivatePuffin
Copy link
Contributor

Afaik some package creators do indeed use it.
It is't technically required for ZFS though...

@behlendorf
Copy link
Contributor

@ndanyluk that's right. If for some reason you needed to update META to get it to build I'd be interested to know why it failed. It's possible some of the downstream distribution packaging may make use of this. But if they're carrying patches for that, it seems reasonable they could manually bump the version in the META file for now as well.

tonyhutter pushed a commit that referenced this pull request Dec 14, 2020
Bump max kernel version to 5.8 to match the supported releases
indicated in the release notes of 0.8.5

Signed-off-by: Nick Danyluk <ndanyluk7@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
iomartin pushed a commit to Eideticom/zfs that referenced this pull request Jan 19, 2021
We squash all upstream commits from this release into one. This includes
the following upstream commits:

2bc6689 "Tag zfs-0.8.6"
033c788 "Restore ARC MFU/MRU pressure"
26a3f3c "Linux 5.10 compat: check_disk_change() removed"
8c7d159 "Linux 5.10 compat: frame.h renamed objtool.h"
38cf54e "blkg_tryget config test: initialize struct"
d7d0752 "copy-builtin: make sure kernel Makefiles don't look in zfs source tree"
3fdfb85 "copy-builtin: don't create sed backup files"
acfc494 "copy-builtin: remove .gitignore from KERNEL_DIR/include/zfs"
0b4f698 "Increase Supported Linux Kernel to 5.9 (openzfs#11057)"
e1be543 "Bump META Linux-Maximum to kernel 5.8 (openzfs#11019)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants