[backport] Remove iov_iter_advance() for iter_write #12178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The additional iter advance is incorrect, as copy_from_iter() has
already done the right thing. This will result in the following
warning being printed to the console as of the 5.12 kernel.
Attempted to advance past end of bvec iter
This change should have been included with #11378 when a
similar change was made on the read side.
Suggested-by: @siebenmann
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Issue #11378
Closes #12041
Closes #12155
(cherry picked from commit 3f81aba)
Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev>
jonathonf
added a commit
to jonathonf/pkgbuilds
that referenced
this pull request
Jun 1, 2021
This includes two further approved backport PRs for the zfs-2.0.5-staging branch (openzfs/zfs#12139, openzfs/zfs#12141) and switches compat patches from 12009 to the merged commits. It also includes backported bugfix openzfs/zfs#12178 .
jonathonf
added a commit
to jonathonf/pkgbuilds
that referenced
this pull request
Jun 1, 2021
This includes two further approved backport PRs for the zfs-2.0.5-staging branch (openzfs/zfs#12139, openzfs/zfs#12141) and switches compat patches from 12009 to the merged commits. It also includes backported bugfix openzfs/zfs#12178 .
behlendorf
approved these changes
Jun 1, 2021
tonyhutter
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR cherry-picks 3f81aba to backport to the zfs-2.0.5-staging branch; this will address #12041 that is being experienced by people running ZFS 2.0.4 with the 5.12 kernel compat patches.
Description
Backport 3f81aba :
The additional iter advance is incorrect, as copy_from_iter() has
already done the right thing. This will result in the following
warning being printed to the console as of the 5.12 kernel.
This change should have been included with #11378 when a
similar change was made on the read side.
Suggested-by: @siebenmann
Reviewed-by: Brian Behlendorf behlendorf1@llnl.gov
Signed-off-by: Rich Ercolani rincebrain@gmail.com
Issue #11378
Closes #12041
Closes #12155
How Has This Been Tested?
Tested on an Arch Linux system with kernel 5.12.8.
Types of changes
Checklist:
Signed-off-by.