Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Man zpool-scrub.8: describe sequential scrub #12429

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Man zpool-scrub.8: describe sequential scrub #12429

merged 1 commit into from
Aug 5, 2021

Conversation

gmelikov
Copy link
Member

Add examples of scrub status and describe what is scanned + issued.

Motivation and Context

Document new scrub mechanism in man pages ( d4a72f2 )

How Has This Been Tested?

man zpool-scrub.8 + CI linting.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@gmelikov gmelikov changed the title Man zpool-scrub.8: describe secuential scrub Man zpool-scrub.8: describe sequential scrub Jul 25, 2021
@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Type: Documentation Indicates a requested change to the documentation labels Jul 26, 2021
behlendorf
behlendorf reviewed Jul 26, 2021
View reviewed changes
man/man8/zpool-scrub.8 Outdated Show resolved Hide resolved
man/man8/zpool-scrub.8 Outdated Show resolved Hide resolved
@behlendorf behlendorf requested a review from rlaager July 26, 2021 18:29
@rlaager
Copy link
Member

rlaager commented Jul 26, 2021

This seems fine to me, with Brian's notes.

@gmelikov
Copy link
Member Author

@behlendorf thank you, applied suggestions as is.

@behlendorf
Copy link
Contributor

@gmelikov would you mind rebasing this again on master.

rlaager
rlaager approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

man/man8/zpool-scrub.8 Outdated Show resolved Hide resolved
@gmelikov
Man zpool-scrub.8: describe sequential scrub
ccbcdb8 
Add examples of scrub status.

Signed-off-by: George Melikov <mail@gmelikov.ru>
@gmelikov
Copy link
Member Author

@behlendorf rebased

@tonynguien tonynguien added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 5, 2021
@tonynguien tonynguien merged commit e1870be into openzfs:master Aug 5, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
@gmelikov @behlendorf
Man zpool-scrub.8: describe sequential scrub
5db46c2 
Describe sequential scrub and add examples of scrub status.

Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#12429
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@gmelikov @behlendorf
Man zpool-scrub.8: describe sequential scrub
c54f874 
Describe sequential scrub and add examples of scrub status.

Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#12429
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@gmelikov
Man zpool-scrub.8: describe sequential scrub
d730594 
Describe sequential scrub and add examples of scrub status.

Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#12429
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@gmelikov @behlendorf
Man zpool-scrub.8: describe sequential scrub
85cabd9 
Describe sequential scrub and add examples of scrub status.

Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#12429
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
@gmelikov @behlendorf
Man zpool-scrub.8: describe sequential scrub
f5160b1 
Describe sequential scrub and add examples of scrub status.

Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes #12429
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@gmelikov @tonyhutter
Man zpool-scrub.8: describe sequential scrub
c07ed69 
Describe sequential scrub and add examples of scrub status.

Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#12429
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
@gmelikov @rincebrain
Man zpool-scrub.8: describe sequential scrub
4189f9c 
Describe sequential scrub and add examples of scrub status.

Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#12429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlaager rlaager rlaager approved these changes

@behlendorf behlendorf behlendorf approved these changes

@tonynguien tonynguien tonynguien approved these changes

Assignees

@tonynguien tonynguien

Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmelikov @rlaager @behlendorf @tonynguien