Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 5.15 compat: get_acl() #12548

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Linux 5.15 compat: get_acl() #12548

merged 1 commit into from
Sep 9, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Address additional Linux 5.15 kernel ABI changes to resolve the build faiilure.

Description

Kernel commits

torvalds/linux@332f606b32b6 ovl: enable RCU'd ->get_acl()
torvalds/linux@0cad6246621b vfs: add rcu argument to ->get_acl() callback

Added compatibility code to detect the new ->get_acl() interface
and correctly handle the case where the new rcu argument is set.

How Has This Been Tested?

Locally compiled using the v5.14-9721-g0bcfe68b8767 kernel. Pending
additional CI testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added Type: Building Indicates an issue related to building binaries Status: Code Review Needed Ready for review and testing labels Sep 8, 2021
@behlendorf
Linux 5.15 compat: get_acl()
f8d0509 
Kernel commits

332f606b32b6 ovl: enable RCU'd ->get_acl()
0cad6246621b vfs: add rcu argument to ->get_acl() callback

Added compatibility code to detect the new ->get_acl() interface
and correctly handle the case where the new rcu argument is set.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@ckane
Copy link
Contributor

ckane commented Sep 9, 2021

I am running this on my system now with the latest 5.15 code (after disabling the CONFIG_TEST and CONFIG_WERROR) and so far it hasn't broken for me yet.

@ckane
Copy link
Contributor

ckane commented Sep 9, 2021

Also appears to pass the acl tests:

Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix-sa/setup (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix-sa/posix_001_pos (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix-sa/posix_002_pos (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix-sa/posix_003_pos (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix-sa/posix_004_pos (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix-sa/cleanup (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix/setup (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix/posix_001_pos (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix/posix_002_pos (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix/posix_003_pos (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix/posix_004_pos (run as root) [00:00] [PASS]
Test (Linux): /usr/local/share/zfs/zfs-tests/tests/functional/acl/posix/cleanup (run as root) [00:00] [PASS]

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 9, 2021
@behlendorf behlendorf merged commit 2079111 into openzfs:master Sep 9, 2021
@satmandu satmandu mentioned this pull request Sep 13, 2021
Merged
13 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@behlendorf @tonyhutter
Linux 5.15 compat: get_acl()
32512ac 
Kernel commits

332f606b32b6 ovl: enable RCU'd ->get_acl()
0cad6246621b vfs: add rcu argument to ->get_acl() callback

Added compatibility code to detect the new ->get_acl() interface
and correctly handle the case where the new rcu argument is set.

Reviewed-by: Coleman Kane <ckane@colemankane.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12548
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 16, 2021
@behlendorf @tonyhutter
Linux 5.15 compat: get_acl()
e0eca8a 
Kernel commits

332f606b32b6 ovl: enable RCU'd ->get_acl()
0cad6246621b vfs: add rcu argument to ->get_acl() callback

Added compatibility code to detect the new ->get_acl() interface
and correctly handle the case where the new rcu argument is set.

Reviewed-by: Coleman Kane <ckane@colemankane.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12548
tonyhutter pushed a commit that referenced this pull request Sep 21, 2021
@behlendorf @tonyhutter
Linux 5.15 compat: get_acl()
04f7f7d 
Kernel commits

332f606b32b6 ovl: enable RCU'd ->get_acl()
0cad6246621b vfs: add rcu argument to ->get_acl() callback

Added compatibility code to detect the new ->get_acl() interface
and correctly handle the case where the new rcu argument is set.

Reviewed-by: Coleman Kane <ckane@colemankane.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #12548
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
@behlendorf @rincebrain
Linux 5.15 compat: get_acl()
d135fa8 
Kernel commits

332f606b32b6 ovl: enable RCU'd ->get_acl()
0cad6246621b vfs: add rcu argument to ->get_acl() callback

Added compatibility code to detect the new ->get_acl() interface
and correctly handle the case where the new rcu argument is set.

Reviewed-by: Coleman Kane <ckane@colemankane.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12548
tonyhutter pushed a commit that referenced this pull request Sep 22, 2021
@behlendorf @tonyhutter
Linux 5.15 compat: get_acl()
7a41ef2 
Kernel commits

332f606b32b6 ovl: enable RCU'd ->get_acl()
0cad6246621b vfs: add rcu argument to ->get_acl() callback

Added compatibility code to detect the new ->get_acl() interface
and correctly handle the case where the new rcu argument is set.

Reviewed-by: Coleman Kane <ckane@colemankane.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #12548
ghost pushed a commit to truenas/zfs that referenced this pull request Oct 7, 2021
@behlendorf
Linux 5.15 compat: get_acl()
7875854 
Kernel commits

332f606b32b6 ovl: enable RCU'd ->get_acl()
0cad6246621b vfs: add rcu argument to ->get_acl() callback

Added compatibility code to detect the new ->get_acl() interface
and correctly handle the case where the new rcu argument is set.

Reviewed-by: Coleman Kane <ckane@colemankane.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @ckane @tonyhutter