Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libshare cleanup, NFS path escaping #13165

Closed
wants to merge 16 commits into from
Closed

libshare cleanup, NFS path escaping #13165

wants to merge 16 commits into from

Commits on May 10, 2022

  1. freebsd: libshare/nfs: constify static const data 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f994f9c View commit details
    Browse the repository at this point in the history

  2. freebsd: libshare/nfs: write directly in translate_opts() 

    This renders it thread-safe

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    ea7be3a View commit details
    Browse the repository at this point in the history

  3. libshare/nfs: destaticify nfs_lock_fd 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    cd85882 View commit details
    Browse the repository at this point in the history

  4. libshare/smb: cleanup 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f1fc801 View commit details
    Browse the repository at this point in the history

  5. libshare: interface: {=> const} char * 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    6527040 View commit details
    Browse the repository at this point in the history

  6. libshare: use AVL tree with static data, pass all data in arguments 

    This makes it so we don't leak a consistent 64 bytes anymore,
makes the searches simpler and faster, removes /all allocations/
from the driver (quite trivially, since they were absolutely needless),
and makes libshare thread-safe (except, maybe, linux/smb, but that only
does pointer-width loads/stores so it's also mostly fine, except for
leaking smb_shares)

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f227363 View commit details
    Browse the repository at this point in the history

  7. libshare: delineate obsolete errors 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f3d1f29 View commit details
    Browse the repository at this point in the history

  8. Publish libshare protocols, use enum-based API 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    522be28 View commit details
    Browse the repository at this point in the history

  9. Replace libzfs sharing _nfs() and _smb() APIs with protocol lists 

    With the additional benefit of removing all the _all() functions and
treating a NULL list as "all" ‒ the remaining all function is for all
/datasets/, which is consistent with the rest of the API

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7fd7e44 View commit details
    Browse the repository at this point in the history

  10. libzfs: mount: zfs_unshare: don't reallocate mountpoint 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    aba67e3 View commit details
    Browse the repository at this point in the history

  11. linux: libshare/nfs: bsearch() over valid keys 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    8ed80bb View commit details
    Browse the repository at this point in the history

  12. libshare/nfs: escape mount points when needed 

    Closes openzfs#13153
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7a2620b View commit details
    Browse the repository at this point in the history

  13. tests: add zfs_unshare_008_pos checking whitespace escaping 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    fc444b9 View commit details
    Browse the repository at this point in the history

  14. libzfs: zfs_unshare: minor cleanup 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    96883d1 View commit details
    Browse the repository at this point in the history

  15. linux: libshare/smb: cache smb_available 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    2eab875 View commit details
    Browse the repository at this point in the history

  16. linux: libshare/nfs: don't do anything unless exportfs is available 

    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13324
    @nabijaczleweli
    nabijaczleweli committed May 10, 2022
    Configuration menu
    Copy the full SHA
    4363ce4 View commit details
    Browse the repository at this point in the history