Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 6.0 compat fix for register_shrinker() now accepting var-arg name via printf-like interface #13748

Merged
merged 1 commit into from Aug 8, 2022
Merged

Linux 6.0 compat fix for register_shrinker() now accepting var-arg name via printf-like interface #13748

merged 1 commit into from Aug 8, 2022

Conversation

ckane
Copy link
Contributor

@ckane ckane commented Aug 6, 2022 •
edited

Motivation and Context

The 6.0 kernel added a printf-style var-arg for args > 0 to the register_shrinker function, in order to add names to shrinkers, in commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Description

Added a new test inside of config/kernel-shrink.m4 that looks for the var-arg version of register_shrinker() first, and if found, it also assumes the split-callback shrinker structure API, as well (which is a pre-requisite for the register_shrinker test). Since spl_register_shrinker is only called in one place (the arc.c code), I embedded the "zfs-arc-shrinker" name in the macro located in include/os/linux/spl/sys/shrinker.h, in order to minimize changes to lines of code. Should we ever want to implement more than one shrinker using this code, we'll have to move the naming out of the macro and into the module code.

How Has This Been Tested?

So far have build tested, will be run-testing this week

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ckane ckane force-pushed the linux-5.20-fix-register_shrinker branch from b729f22 to 2ac6f09 Compare August 6, 2022 20:33
@ckane
Copy link
Contributor Author

ckane commented Aug 6, 2022

@behlendorf I have got zero clue why the CI/CD test builds fail around the "checking for parallel" line in configure, but I've built this on my Arch linux system multiple times and it works there. the kernel boots and seems to work, although latest pulls in some other regressions related to AMDGPU that were reverted in 5.19, which causes my kernel to crash shortly after starting, so I don't get much run-testing.

@ckane ckane force-pushed the linux-5.20-fix-register_shrinker branch from 2ac6f09 to a94f303 Compare August 6, 2022 21:18
@ckane ckane changed the title Linux 5.20 compat fix for register_shrinker() now accepting var-arg name via printf-like interface Linux 6.0 compat fix for register_shrinker() now accepting var-arg name via printf-like interface Aug 6, 2022
@ckane
Linux 6.0 compat: register_shrinker() now var-arg
2598eb8 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Signed-off-by: Coleman Kane <ckane@colemankane.org>
@ckane ckane force-pushed the linux-5.20-fix-register_shrinker branch from a94f303 to 2598eb8 Compare August 7, 2022 15:45
@ckane
Copy link
Contributor Author

ckane commented Aug 7, 2022

Ok, looks like an issue with the older versions of automake/autoconf that come with Ubuntu and how it handles newlines within [] constructs. I tried the configure again in a Ubuntu docker, was able to reproduce the issue seen in the GitHub workflows, and cleaned up Line 138 in config/kernel-shrink.m4 and it resolved the syntax error messages.

@behlendorf behlendorf merged commit ad09676 into openzfs:master Aug 8, 2022
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Aug 8, 2022
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 8, 2022
@ckane @behlendorf
Linux 6.0 compat: register_shrinker() now var-arg
e269255 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
behlendorf pushed a commit that referenced this pull request Aug 9, 2022
@ckane @behlendorf
Linux 6.0 compat: register_shrinker() now var-arg
e0dbab1 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes #13748
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@ckane @nicman23
Linux 6.0 compat: register_shrinker() now var-arg
c5eacc5 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@ckane @nicman23
Linux 6.0 compat: register_shrinker() now var-arg
8acc00b 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 13, 2022
@ckane @lundman
Linux 6.0 compat: register_shrinker() now var-arg
2f48881 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@ckane @beren12
Linux 6.0 compat: register_shrinker() now var-arg
d4e7ae2 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
a7c87a4 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
13ab10b 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
8392965 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
71e4704 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
ccb5c30 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
696c741 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
8cd918f 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
dd06681 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
fa6dfab 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
a99cace 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
d0bb4eb 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
d5a2068 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
6deaeaf 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
8b77897 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
1bf3bc0 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
48ad263 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
ae15c3e 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
00c0e78 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
655aa93 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
492743a 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
c2b32e1 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
604c1d8 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
cc8dfd7 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
edfa868 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
0c16da9 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
7da0477 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
73cb6bd 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
84dfb57 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
2fc2a2d 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
a79599b 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
347df3d 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
84a2d6b 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@ckane @andrewc12
Linux 6.0 compat: register_shrinker() now var-arg
6660be4 
The 6.0 kernel added a printf-style var-arg for args > 0 to the
register_shrinker function, in order to add names to shrinkers, in
commit e33c267ab70de4249d22d7eab1cc7d68a889bac2. This enables the
shrinkers to have friendly names exposed in /sys/kernel/debug/shrinker/.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#13748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ckane @behlendorf @tonyhutter