readmmap.c: fix building with MUSL libc #15130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibc includes sys/types.h from stdlib.h. This is not the case for MUSL, so explicitly include it. Fixes usage of uint_t. Signed-off-by: Zach Dykstra <dykstra.zachary@gmail.com>
behlendorf
approved these changes
Aug 1, 2023
|
That was the only issue I hit when building 2.2.0-rc3 with MUSL - though I haven't actually tested the build product. |
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Aug 1, 2023
glibc includes sys/types.h from stdlib.h. This is not the case for MUSL, so explicitly include it. Fixes usage of uint_t. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Zach Dykstra <dykstra.zachary@gmail.com> Closes openzfs#15130
7 tasks
behlendorf
pushed a commit
that referenced
this pull request
Aug 2, 2023
glibc includes sys/types.h from stdlib.h. This is not the case for MUSL, so explicitly include it. Fixes usage of uint_t. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Zach Dykstra <dykstra.zachary@gmail.com> Closes #15130
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
glibc includes sys/types.h from stdlib.h. This is not the case for MUSL, so explicitly include it. Fixes usage of uint_t. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Zach Dykstra <dykstra.zachary@gmail.com> Closes openzfs#15130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix building
readmmap.cwith MUSL libc.Description
glibc includes sys/types.h from stdlib.h. This is not the case for MUSL, so explicitly include it.
How Has This Been Tested?
Tested using Void's cross-compiling infrastructure - https://github.com/void-linux/void-packages/pull/45365/checks
Types of changes
Checklist:
Signed-off-by.