-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfs: update to 2.2.0, add zfs-lts package #45365
Conversation
Upstream fix for the broken test cmd at openzfs/zfs#15130 |
On the last coreutils update, this was reported: Locally I get a fail in tests/cp/sparse-2.sh, but I'm on ZFS... |
I tested this PR on
Something similar happens with version 2.1.12. Does upstream have any patches to avoid this? |
Looks like this is a reiteration of openzfs/zfs#14555 . I don't see any real closure to that issue. Does |
No, it doesn't. The log is almost identical.
I think there are at least two possible workarounds that a) don't require changes to the kernel at all and b) don't require heavy patching of zfs. I briefly tested them and they both allow zfs to compile and install (but I didn't test at run-time yet).
The first approach may reduce the performance (but I didn't measure). |
Determining which course of action to follow is in @Vaelatern's court. Barring any additional input from him, I won't take any action to resolve this, for now. |
Huh, the Chimera patch references a closed/solved issue. I'm going to read on this a bit more. I don't like lying about licenses, and I also don't like randomly disabling the instructions upstream uses. |
@r-ricci could we tell ZFS to lie about its license only on aarch64? Having read the justification for the GPL symbol limit (that it's meant for internal-only interfaces that could only have violated the GPL unless GPL), I think such a patch, on the user's machine, just before running DKMS, only on neon architectures, would be reasonable. This might be the right solution for now while upstream linux and zfs fight it out. |
Technically yes, legally I don't know. Did you read https://lwn.net/Articles/154602/?
|
Let's make the META file a conf file. Let's also leave it as default broken on aarch64. Let's finally consider documenting this on the void linux doc site... and leave an open issue in void-packages about zfs being broken on aarch64, so others may change the license and get a full speed ZFS themselves. |
Bug report opened at #45552 and referenced in the template. Marked as broken on |
Does /usr/src/zfs/zfs-${version}/META need to be marked as a configuration file? Any future updates to ZFS will install under a different versioned directory. |
it would get overwritten on reinstalls of the same version (or revbumps) |
ae460e7
to
f9ce86e
Compare
Based on what I'm reading and seeing, the ZFS 2.1.x branch is going to continue to receive fixes and back-ports. https://github.com/openzfs/zfs/tree/zfs-2.1.13-staging exists, and there's at least one open PR for cherry picked fixes going to that branch. Do we want to consider offering a |
Is it officially "LTS" or just a special one-time support for 2.1? |
It's officially an LTS release; https://github.com/openzfs/zfs/blob/master/RELEASES.md |
if we do it, maybe call it zfs-lts so we don't have to add/remove packages for later LTS? |
"New kernel versions released after the OpenZFS LTS release are not supported" concerns me. We already hold moving the |
I'd say that |
81844a7
to
125054f
Compare
The lint stage is failing because I'm starting |
This comment was marked as off-topic.
This comment was marked as off-topic.
f271d34
to
076a41e
Compare
Let's let this sit for a day or two, just to let other people test first, then 👍 |
I'm very excited about corrective zfs receive |
I'm very excited about block cloning. |
I'm very excited about container support stuff |
That works very well, but be aware that you won't be able to clone between datasets if you use encryption.
I've been testing 2.2 for weeks and it's mostly rock solid. I've encountered a single data corrupting bug but they managed to reproduce it and temporarily disable the offending feature just in the time for the stable release. |
Oh boy have I been waiting for this! Can confirm what @Vaelatern said; pool cannot be used with older zfs version if upgraded. Without thinking it about it I upgraded my pools from arch linux which had zfs-git installed and since then I have been manually installing zfs 2.2-rc versions on my void. 😅 |
@zdykstra I can't IRC right now, but 👍 for this. |
Testing the changes
Place-holder PR so that we can get this out the door once
2.2.0
officially lands.