Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Fix 'could not unmount datasets' on Alma 9 #15542

Merged
merged 1 commit into from
Nov 21, 2023
Merged

ZTS: Fix 'could not unmount datasets' on Alma 9 #15542

merged 1 commit into from
Nov 21, 2023

Conversation

tonyhutter
Copy link
Contributor

@tonyhutter tonyhutter commented Nov 18, 2023 •
edited
Loading

Motivation and Context

Fix test failures on AlmaLinux 9

Description

Many tests are failing on AlmaLinux 9 because ZTS could not destroy the pool in cleanup:

20:21:16.57 cannot unmount '/var/tmp/testdir': pool or dataset is busy
20:21:16.57 could not destroy 'testpool': could not unmount datasets

Tests with results other than PASS that are unexpected:
    FAIL cli_root/zfs_destroy/zfs_destroy_004_pos (expected PASS)
    FAIL cli_root/zfs_destroy/zfs_destroy_005_neg (expected PASS)
    FAIL cli_root/zfs_destroy/zfs_destroy_008_pos (expected PASS)
    FAIL cli_root/zfs_destroy/zfs_destroy_009_pos (expected PASS)
    FAIL cli_root/zfs_destroy/zfs_destroy_010_pos (expected PASS)
    FAIL cli_root/zfs_destroy/zfs_destroy_011_pos (expected PASS)
    FAIL cli_root/zfs_destroy/zfs_destroy_012_pos (expected PASS)
    FAIL cli_root/zfs_destroy/zfs_destroy_013_neg (expected PASS)
    FAIL cli_root/zfs_destroy/zfs_destroy_015_pos (expected PASS)
    FAIL cli_root/zfs_set/canmount_003_pos (expected PASS)
    FAIL cli_root/zfs_set/readonly_001_pos (expected PASS)
    FAIL cli_root/zfs_share/zfs_share_011_pos (expected PASS)
    FAIL cli_root/zfs_unmount/zfs_unmount_005_pos (expected PASS)
    FAIL cli_root/zpool_export/zpool_export_002_pos (expected PASS)
    FAIL io/io_uring (expected PASS)
    FAIL snapshot/snapshot_017_pos (expected PASS)

This was due to $PWD being set to '.' instead of the expected full path. This patch sets $PWD to the full path.

How Has This Been Tested?

Ran test suite locally. Buildbot will test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@tonyhutter tonyhutter mentioned this pull request Nov 18, 2023
Merged
13 tasks
@tonyhutter
ZTS: Fix 'could not unmount datasets' on Alma 9
d6033a8 
Many tests are failing on AlmaLinux 9 because ZTS could not destroy the
pool in cleanup.  This was due to $PWD being set to '.' instead of the
expected full path.  This patch sets $PWD to the full path.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
@tonyhutter
Copy link
Contributor Author

This one looks good to go. Alma 9 is only failing on io/io_uring which looks to be unrelated.

@tonyhutter tonyhutter added Status: Code Review Needed Ready for review and testing Component: Test Suite Indicates an issue with the test framework or a test case labels Nov 20, 2023
don-brady
don-brady approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@don-brady don-brady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyhutter tonyhutter merged commit a94860a into openzfs:master Nov 21, 2023
23 of 26 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@tonyhutter @lundman
ZTS: Fix 'could not unmount datasets' on Alma 9 (openzfs#15542)
74b7bba 
Many tests are failing on AlmaLinux 9 because ZTS could not destroy the
pool in cleanup.  This was due to $PWD being set to '.' instead of the
expected full path.  This patch sets $PWD to the full path.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
behlendorf pushed a commit that referenced this pull request Feb 13, 2024
@tonyhutter @behlendorf
ZTS: Fix 'could not unmount datasets' on Alma 9 (#15542)
bc42a2f 
Many tests are failing on AlmaLinux 9 because ZTS could not destroy the
pool in cleanup.  This was due to $PWD being set to '.' instead of the
expected full path.  This patch sets $PWD to the full path.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@don-brady don-brady don-brady approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyhutter @don-brady