Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Update deprecated Github Action version numbers #15820

Merged
merged 1 commit into from Jan 26, 2024

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Jan 25, 2024

Motivation and Context

GitHub Actions is transitioning from Node 16 to Node 20.

So we need to update these:
actions/checkout@v3 -> v4
actions/download-artifact@v3 -> v4
actions/upload-artifact@v3 -> v4

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mcmilk mcmilk marked this pull request as draft January 25, 2024 06:44
@mcmilk
Copy link
Contributor Author

mcmilk commented Jan 25, 2024

A fix for the upload is needed, I will force push some changes later.

GitHub Actions is transitioning from Node 16 to Node 20.

So we need to update these:
- actions/checkout@v3 -> v4
- actions/download-artifact@v3 -> v4
- actions/upload-artifact@v3 -> v4 and some minor changes

Update also the documentation of the testings workflow.

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
@mcmilk mcmilk marked this pull request as ready for review January 25, 2024 11:56
end

subgraph Functional Testings
sanity-checks-20.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be in this subgraph?

Copy link
Contributor Author

@mcmilk mcmilk Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the results of them go into the CleanUp+Summary thing in the end.

Should I put it into the Functional Testing area and create sth. like a Sanity-Result-20.04 - which is then within CleanUp+Summary area?

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jan 26, 2024
@behlendorf behlendorf merged commit fb27698 into openzfs:master Jan 26, 2024
23 of 25 checks passed
@andrewc12
Copy link
Contributor

The generated graph seems broken.
I'll do a pr.

@andrewc12
Copy link
Contributor

Current graph
github com_andrewc121

My proposal
github com_andrewc122

Is this better?

@andrewc12 andrewc12 mentioned this pull request Jan 27, 2024
13 tasks
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jan 29, 2024
GitHub Actions is transitioning from Node 16 to Node 20.

So we need to update these:
- actions/checkout@v3 -> v4
- actions/download-artifact@v3 -> v4
- actions/upload-artifact@v3 -> v4 and some minor changes

Update also the documentation of the testings workflow.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Andrew Innes <andrew.c12@gmail.com>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#15820
behlendorf pushed a commit that referenced this pull request Jan 29, 2024
GitHub Actions is transitioning from Node 16 to Node 20.

So we need to update these:
- actions/checkout@v3 -> v4
- actions/download-artifact@v3 -> v4
- actions/upload-artifact@v3 -> v4 and some minor changes

Update also the documentation of the testings workflow.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Andrew Innes <andrew.c12@gmail.com>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes #15820
@mcmilk mcmilk deleted the zts-gh-versions branch January 30, 2024 18:26
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
GitHub Actions is transitioning from Node 16 to Node 20.

So we need to update these:
- actions/checkout@v3 -> v4
- actions/download-artifact@v3 -> v4
- actions/upload-artifact@v3 -> v4 and some minor changes

Update also the documentation of the testings workflow.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Andrew Innes <andrew.c12@gmail.com>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#15820
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
GitHub Actions is transitioning from Node 16 to Node 20.

So we need to update these:
- actions/checkout@v3 -> v4
- actions/download-artifact@v3 -> v4
- actions/upload-artifact@v3 -> v4 and some minor changes

Update also the documentation of the testings workflow.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Andrew Innes <andrew.c12@gmail.com>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#15820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants