Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nodes into correct subgraphs #15828

Merged
merged 1 commit into from Jan 29, 2024
Merged

Move nodes into correct subgraphs #15828

merged 1 commit into from Jan 29, 2024

Conversation

andrewc12
Copy link
Contributor

@andrewc12 andrewc12 commented Jan 27, 2024 •
edited

Change the flowchart to move the nodes into the correct subgraphs

Current graph
github com_andrewc121
Proposal
github com_andrewc122

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@andrewc12
Move nodes into correct subgraphs
5a45213 
Signed-off-by: Andrew Innes <andrew.c12@gmail.com>
@andrewc12
Copy link
Contributor Author

@mcmilk the PR as promised in #15820

@andrewc12
Copy link
Contributor Author

To avoid problems with placement I added node definitions in the subgraphs and moved the inter-subgraph edge definitions to the end.

@behlendorf behlendorf merged commit 3965c9b into openzfs:master Jan 29, 2024
22 of 25 checks passed
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jan 29, 2024
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jan 29, 2024
@andrewc12 @behlendorf
Move nodes into correct subgraphs
eea31ae 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Andrew Innes <andrew.c12@gmail.com>
Closes openzfs#15828
@andrewc12 andrewc12 deleted the graph4 branch January 29, 2024 22:49
behlendorf pushed a commit that referenced this pull request Jan 29, 2024
@andrewc12 @behlendorf
Move nodes into correct subgraphs
7cd666d 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Andrew Innes <andrew.c12@gmail.com>
Closes #15828
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
@andrewc12 @lundman
Move nodes into correct subgraphs
2a3b0c4 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Andrew Innes <andrew.c12@gmail.com>
Closes openzfs#15828
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
@andrewc12 @lundman
Move nodes into correct subgraphs
b85df5f 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Andrew Innes <andrew.c12@gmail.com>
Closes openzfs#15828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@mcmilk mcmilk mcmilk approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewc12 @behlendorf @mcmilk @gmelikov