Ensure arc_size_break are filled in arc_summary.py #6770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Oct 19, 2017
|
As mentioned in issue #5526 we really should fix this and directly use |
dinatale2
force-pushed
the
arcsummary-fix
branch
from
4e3ca53
to
cc8a63c
Compare
|
Updated to resolve issue #5526. |
behlendorf
requested changes
Oct 19, 2017
cmd/arc_summary/arc_summary.py
Outdated
| @@ -241,8 +241,7 @@ def get_arc_summary(Kstat): | |||
| 'num': fBytes(mfu_size), | |||
| } | |||
|
|
|||
| elif arc_size < target_size: | |||
| mfu_size = (target_size - mru_size) | |||
| else: | |||
There was a problem hiding this comment.
I'd argue that what we really want to report here is the mru/fmu percentages independent of the arc size. In which case the conditional can be removed and this can be calculated as.
mru_per = fPerc(mru_size, mru_size + mfu_size)
mfu_per = fPerc(mfu_size, mru_size + mfu_size)
Use mfu_size and mru_size pulled from the arcstats kstat file to calculate the mfu and mru percentages for arc size breakdown. Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
dinatale2
force-pushed
the
arcsummary-fix
branch
from
cc8a63c
to
72f98d0
Compare
behlendorf
approved these changes
Oct 20, 2017
behlendorf
added
Ready for Testing
and removed
Status: Work in Progress
gmelikov
approved these changes
Oct 20, 2017
Codecov Report
@@ Coverage Diff @@
## master #6770 +/- ##
==========================================
+ Coverage 74.36% 74.51% +0.14%
==========================================
Files 297 297
Lines 94371 94371
==========================================
+ Hits 70181 70317 +136
+ Misses 24190 24054 -136
Continue to review full report at Codecov.
|
|
@AndCycle @richardelling it'd be great to get your thoughts on this little bit of cleanup. The notion here is to simply update the script to give you an authoritative breakdown of the mru/mfu split. Nothing fancy. |
|
Agree, let's use the metrics at our disposal. +1 |
|
LGTM |
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Nov 4, 2017
Use mfu_size and mru_size pulled from the arcstats kstat file to calculate the mfu and mru percentages for arc size breakdown. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by: AndCycle <andcycle@andcycle.idv.tw> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#5526 Closes openzfs#6770
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Nov 6, 2017
Use mfu_size and mru_size pulled from the arcstats kstat file to calculate the mfu and mru percentages for arc size breakdown. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by: AndCycle <andcycle@andcycle.idv.tw> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#5526 Closes openzfs#6770
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 21, 2017
Use mfu_size and mru_size pulled from the arcstats kstat file to calculate the mfu and mru percentages for arc size breakdown. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by: AndCycle <andcycle@andcycle.idv.tw> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#5526 Closes openzfs#6770
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Jan 29, 2018
Use mfu_size and mru_size pulled from the arcstats kstat file to calculate the mfu and mru percentages for arc size breakdown. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by: AndCycle <andcycle@andcycle.idv.tw> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#5526 Closes openzfs#6770
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Feb 13, 2018
Use mfu_size and mru_size pulled from the arcstats kstat file to calculate the mfu and mru percentages for arc size breakdown. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by: AndCycle <andcycle@andcycle.idv.tw> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#5526 Closes openzfs#6770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When printing output in arc_summary, all possible keys
are expected in the output data structure. For the arc
size breakdown, output is conditionally filled and does
not expect arc target size to be equal to the arc size.
Motivation and Context
Just a small bug fix.
How Has This Been Tested?
Locally, on a VM.
Types of changes
Checklist:
Signed-off-by.