Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Clarify loop variable name in zfs copies test #9445

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2019

Signed-off-by: Ryan Moeller ryan@iXsystems.com

Motivation and Context

The loop variable name "val" is ambiguous.

Description

do_vol_test takes the number of copies as the second parameter, so name the loop variable copies instead of val.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Oct 10, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #9445 into master will increase coverage by 11.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9445       +/-   ##
===========================================
+ Coverage      68%   79.17%   +11.16%     
===========================================
  Files         365      412       +47     
  Lines      117487   123602     +6115     
===========================================
+ Hits        79895    97857    +17962     
+ Misses      37592    25745    -11847
Flag Coverage Δ
#kernel 79.73% <ø> (+12.57%) ⬆️
#user 67.04% <ø> (+6.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3dc4a8...925250e. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 11, 2019
@behlendorf behlendorf merged commit d96635a into openzfs:master Oct 11, 2019
@ghost ghost deleted the vol_copies-test branch October 11, 2019 17:37
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 26, 2019
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#9445
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#9445
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #9445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants