Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zim creator finalize() should clean all the temporary fields #348

Closed
kelson42 opened this issue Jun 11, 2020 · 0 comments · Fixed by #603
Closed

Zim creator finalize() should clean all the temporary fields #348

kelson42 opened this issue Jun 11, 2020 · 0 comments · Fixed by #603
Assignees
@mgautierfr
Labels
enhancement good first issue
Milestone
7.0.0

Comments

@kelson42
Copy link
Contributor

There is no reason to keep these files after this stage.

Remark: I would keep the cleaning in the destructor as well.

Related to #347
@kelson42 kelson42 changed the title Zim creator finalize() should clean all the temporary fiels Zim creator finalize() should clean all the temporary fields Jun 25, 2020
@kelson42 kelson42 mentioned this issue Jul 11, 2020
Closed
@kelson42 kelson42 added this to the libzim 7.0.0 milestone Mar 24, 2021
mgautierfr added a commit that referenced this issue Aug 10, 2021
@mgautierfr
Clear the handlers when we don't need them.
5665796 
The temporary data (idx files) are removed by the indexer destructor.
By deleting the handlers, we ensure we remove the temporary files as
soon we don't need them.

Fix #348
@mgautierfr mgautierfr mentioned this issue Aug 10, 2021
Merged
@kelson42 kelson42 mentioned this issue Feb 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgautierfr mgautierfr

Labels
enhancement good first issue
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Remove temporary files when we call finishZimCreation. openzim/libzim
2 participants
@mgautierfr @kelson42