Remove temporary files when we call finishZimCreation. #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A time ago, the `write` method were writing everything. But now, we are writing the clusters data during the creation. So we are actually writing only the last parts (indexes, cluster offsets..)
We also call the helper from the destructor. This way threads are destroyed correctly even if user don't call `finishZimCreation`.
The temporary data (idx files) are removed by the indexer destructor. By deleting the handlers, we ensure we remove the temporary files as soon we don't need them. Fix #348
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
==========================================
+ Coverage 82.78% 82.81% +0.03%
==========================================
Files 91 91
Lines 3822 3829 +7
Branches 1703 1705 +2
==========================================
+ Hits 3164 3171 +7
Misses 657 657
Partials 1 1
Continue to review full report at Codecov.
|
veloman-yunkan
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #348