Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mw:File typeof #1636

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Add support for mw:File typeof #1636

merged 1 commit into from
Jul 10, 2022

Conversation

arlolra
Copy link
Contributor

@arlolra arlolra commented Jun 14, 2022

Coming in Parsoid's content version 2.5.0

Bug: T273505

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1636 (c017ca8) into master (0d5f4fc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1636   +/-   ##
=======================================
  Coverage   69.42%   69.42%           
=======================================
  Files          26       26           
  Lines        2401     2401           
  Branches      469      469           
=======================================
  Hits         1667     1667           
  Misses        569      569           
  Partials      165      165           
Impacted Files Coverage Δ
src/util/saveArticles.ts 83.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fda448...c017ca8. Read the comment docs.

@kelson42
Copy link
Collaborator

@arlolra Thx for your PR, will make a review in the next days.

@kelson42 kelson42 self-requested a review June 15, 2022 07:51
@kelson42 kelson42 added this to the 1.12.0 milestone Jun 15, 2022
Coming in Parsoid's content version 2.5.0

Bug: T273505
@kelson42 kelson42 merged commit 5b5cbdd into openzim:master Jul 10, 2022
@kelson42 kelson42 modified the milestones: 1.12.0, 1.11.12 Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants