Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #160 - Fail properly on downloads #164

Closed
wants to merge 2 commits into from
Closed

Conversation

satyamtg
Copy link
Contributor

@satyamtg satyamtg commented Nov 1, 2020

Will potentially fix #160. Will update description after testing.

@stale
Copy link

stale bot commented Nov 8, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 8, 2020
@kelson42
Copy link
Contributor

kelson42 commented Jan 7, 2021

@satyamtg Any chance this PR could be easily completed?

@stale stale bot removed the stale label Jan 7, 2021
@satyamtg
Copy link
Contributor Author

satyamtg commented Jan 8, 2021

@satyamtg Any chance this PR could be easily completed?

Yep. I'll test once and push updates.

@stale
Copy link

stale bot commented Jan 15, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jan 15, 2021
@kelson42
Copy link
Contributor

kelson42 commented Mar 6, 2021

@satyamtg Any chance you could find a few hours to complete this PR please?

@stale stale bot removed the stale label Mar 6, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Mar 19, 2021
@benoit74
Copy link
Collaborator

Probably superseeded by #178 which is working ok (the code in this PR was fairly limited to only few kinds of resources, the one in #178 is way more generic)

@stale stale bot removed the stale label Jul 11, 2023
@rgaudin rgaudin closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail on missing resources
4 participants