Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic with detailled logs to extraction of video data #214

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #209

@benoit74 benoit74 self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 5.03%. Comparing base (9fc26d4) to head (62cfc3c).

Files Patch % Lines
src/ted2zim/scraper.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #214      +/-   ##
========================================
- Coverage   5.05%   5.03%   -0.03%     
========================================
  Files          8       8              
  Lines       1088    1093       +5     
  Branches     237     238       +1     
========================================
  Hits          55      55              
- Misses      1032    1037       +5     
  Partials       1       1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the resilient_extract_video_page branch from e4b0fde to 2829651 Compare July 10, 2024 12:39
@benoit74 benoit74 force-pushed the resilient_extract_video_page branch from 669da9b to 97d8ade Compare July 10, 2024 12:44
@benoit74 benoit74 force-pushed the resilient_extract_video_page branch from ab8ae60 to 62cfc3c Compare July 10, 2024 12:47
@benoit74 benoit74 marked this pull request as ready for review July 10, 2024 12:48
@benoit74 benoit74 requested a review from rgaudin July 10, 2024 12:48
@benoit74
Copy link
Collaborator Author

@rgaudin I'll merge this because it is way too annoying and I want to release this asap, but feedback is still welcomed.

@benoit74 benoit74 merged commit a586a69 into main Jul 10, 2024
8 checks passed
@benoit74 benoit74 deleted the resilient_extract_video_page branch July 10, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore functionality to resist temporary bad TED responses when parsing video pages
1 participant