Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to generate Phets ZIM files #76

Closed
kelson42 opened this issue Dec 9, 2018 · 1 comment
Closed

Be able to generate Phets ZIM files #76

kelson42 opened this issue Dec 9, 2018 · 1 comment
Assignees
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Dec 9, 2018

We have scrapper for Phets https://phet.colorado.edu/. It is available herer: https://hub.docker.com/r/openzim/phet/. Be just calling npm start is generate all the Phets ZIM files in one directory.

@kelson42 kelson42 added this to the 1.0 milestone Apr 14, 2019
@rgaudin
Copy link
Member

rgaudin commented May 15, 2019

FYI openzim/phet#48

rgaudin added a commit that referenced this issue May 20, 2019
Using similar structure as for MWOffliner:
- A task launching a phet container then uploading files
- An operation to pull and start the phet container

Adapted validators as there flags is not tied to mwoffliner anymore.
Added some tests.

Worth nothing that while flags are now validated based on the requested task
all other fields are flexible (image, for instance).
We shall discuss how much we want to enforce rules on config.
kelson42 pushed a commit that referenced this issue Feb 19, 2020
* Fixed #76: phet tasks for worker

Using similar structure as for MWOffliner:
- A task launching a phet container then uploading files
- An operation to pull and start the phet container

Adapted validators as there flags is not tied to mwoffliner anymore.
Added some tests.

Worth nothing that while flags are now validated based on the requested task
all other fields are flexible (image, for instance).
We shall discuss how much we want to enforce rules on config.

* fixed typo
kelson42 pushed a commit that referenced this issue Feb 19, 2020
* Fixed #76: phet tasks for worker

Using similar structure as for MWOffliner:
- A task launching a phet container then uploading files
- An operation to pull and start the phet container

Adapted validators as there flags is not tied to mwoffliner anymore.
Added some tests.

Worth nothing that while flags are now validated based on the requested task
all other fields are flexible (image, for instance).
We shall discuss how much we want to enforce rules on config.

* fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants