Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube offliner definition update (new flag + remove playlist mode) + fix TED offliner definition #974

Merged
merged 2 commits into from
May 28, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented May 22, 2024

Fix #878

Changes

  • add new long_description field to youtube offliner definition
  • fix field type of TED long_description (was String instead of LongString)
  • remove all "playlist-mode" youtube flags (including metadata-from) and change utility to youtube2zim
  • remove any reference to "Single mode" in remaining youtube flags descriptions

Nota:

SQL updates will have to be ran manually to get rid of removed config flags

UPDATE schedule SET config = config::jsonb #- '{flags, indiv-playlists}'
WHERE config::jsonb -> 'flags' -> 'indiv-playlists' IS NOT NULL
AND config::jsonb -> 'image' ->> 'name' = 'ghcr.io/openzim/youtube';

UPDATE schedule SET config = config::jsonb #- '{flags, playlists-name}'
WHERE config::jsonb -> 'flags' -> 'playlists-name' IS NOT NULL
AND config::jsonb -> 'image' ->> 'name' = 'ghcr.io/openzim/youtube';

UPDATE schedule SET config = config::jsonb #- '{flags, playlists-zim-file}'
WHERE config::jsonb -> 'flags' -> 'playlists-zim-file' IS NOT NULL
AND config::jsonb -> 'image' ->> 'name' = 'ghcr.io/openzim/youtube';

UPDATE schedule SET config = config::jsonb #- '{flags, playlists-title}'
WHERE config::jsonb -> 'flags' -> 'playlists-title' IS NOT NULL
AND config::jsonb -> 'image' ->> 'name' = 'ghcr.io/openzim/youtube';

UPDATE schedule SET config = config::jsonb #- '{flags, playlists-description}'
WHERE config::jsonb -> 'flags' -> 'playlists-description' IS NOT NULL
AND config::jsonb -> 'image' ->> 'name' = 'ghcr.io/openzim/youtube';

UPDATE schedule SET config = config::jsonb #- '{flags, metadata-from}'
WHERE config::jsonb -> 'flags' -> 'metadata-from' IS NOT NULL
AND config::jsonb -> 'image' ->> 'name' = 'ghcr.io/openzim/youtube';

@benoit74 benoit74 self-assigned this May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (294fe29) to head (be75cc5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
+ Coverage   88.05%   88.11%   +0.06%     
==========================================
  Files          94       94              
  Lines        5315     5303      -12     
==========================================
- Hits         4680     4673       -7     
+ Misses        635      630       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review May 22, 2024 15:29
@benoit74 benoit74 requested a review from rgaudin May 22, 2024 15:29
@benoit74 benoit74 changed the title Add long_description flag to Youtube recipes (and fix field type for TED) Youtube offliner definition update (new flag + remove playlist mode) + fix TED offliner definition May 22, 2024
@benoit74 benoit74 mentioned this pull request May 22, 2024
17 tasks
@benoit74
Copy link
Collaborator Author

@rgaudin may I proceed?

@benoit74 benoit74 merged commit e6a19db into main May 28, 2024
7 checks passed
@benoit74 benoit74 deleted the youtube_long_desc branch May 28, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ability for youtube scraper to create multiple ZIM (one per playlist)
2 participants