Adds http.method tag by default and removes bad naming advice #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the http.method tag by default as many frameworks override
the span name, or will as soon as http.route is supported. This allows
users to always see basic http info at the cost of a small, fixed
cardinality tag. Users who really don't want to see this tag can already
disable parsing of it by overriding the default parser.
This also removes the bad advice from the README, which hinted at using
a path as a span name. This will result in ever-expanding span name
index when there are path variables. The http route based approach is
superior and merges next.