Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds http.method tag by default and removes bad naming advice #616

Merged
merged 1 commit into from Feb 22, 2018

Conversation

codefromthecrypt
Copy link
Member

This adds the http.method tag by default as many frameworks override
the span name, or will as soon as http.route is supported. This allows
users to always see basic http info at the cost of a small, fixed
cardinality tag. Users who really don't want to see this tag can already
disable parsing of it by overriding the default parser.

This also removes the bad advice from the README, which hinted at using
a path as a span name. This will result in ever-expanding span name
index when there are path variables. The http route based approach is
superior and merges next.

This adds the http.method tag by default as many frameworks override
the span name, or will as soon as http.route is supported. This allows
users to always see basic http info at the cost of a small, fixed
cardinality tag. Users who really don't want to see this tag can already
disable parsing of it by overriding the default parser.

This also removes the bad advice from the README, which hinted at using
a path as a span name. This will result in ever-expanding span name
index when there are path variables. The http route based approach is
superior and merges next.
@codefromthecrypt codefromthecrypt merged commit 7696082 into master Feb 22, 2018
@codefromthecrypt codefromthecrypt deleted the method4evar branch February 22, 2018 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants