Add Logger reporter option to http reporter #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
|
Hi @forrest-ua, thanks for the contribution. I'm willing to consider adding this for now. Please note that this is by no means a permanent fix as I prefer to refactor inner library logging to using a structured logging approach as highlighted in #37. |
|
Great work Sergii. I think in practice this will overcome the issue
#91
|
|
BTW, this does not only allow users to use a prefix but also to pass a
`component` keyVal by default in structured logging.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR adds ability to override default logger. It comes in handy when you need to set a custom prefix for all the logs coming from zipkin library.