-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve failure messages for reporting #91
Comments
if logging probably saying the endpoint is enough to clarify.
…On Wed, 7 Nov 2018, 22:39 José Carlos Chávez, ***@***.***> wrote:
Error log messages for reporting are meaningless
https://github.com/openzipkin/zipkin-go/blob/master/reporter/http/http.go#L139
end up in 2018/11/07 13:28:24 failed the request with status code 503 in
logs which might not be useful. I was thinking on 2018/11/07 13:28:24
failed the request to zipkin collector with status code 503 Any
suggestion @adriancole <https://github.com/adriancole> @basvanbeek
<https://github.com/basvanbeek> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD614vk8FqpfXZoIohNoYIN9kajEb1Cks5usvCPgaJpZM4YSja2>
.
|
@adriancole I actually see the value of printing both, sometimes you don't know what
|
I think logging inside zipkin-go still needs a major overhaul. We shouldn't make assumptions on how stuff is being logged from within a library... that's an application concern. Let's fix that and see what we need to do to improve reporting quality. See #37 |
Since we are injecting a logger there is not much application can control
(more than an mdc). My only point here is that those isolated messages are
not understandable per se, people usually copy the text and look into the
application code because they are kinda críptic. I do agree we need to
improve the logging but I also think improving the message is a quick win.
Den man. 3. des. 2018, 17:01 skrev Bas van Beek <notifications@github.com:
… I think logging inside zipkin-go still needs a major overhaul. We
shouldn't make assumptions on how stuff is being logged from within a
library... that's an application concern.
Let's fix that and see what we need to do to improve reporting quality.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC7sAnY0_PzBT1dj4t02PoR7ZheB4iDoks5u1UrpgaJpZM4YSja2>
.
|
Error log messages for reporting are meaningless https://github.com/openzipkin/zipkin-go/blob/master/reporter/http/http.go#L139 end up in
in logs which might not be useful. I was thinking on
Any suggestion @adriancole @basvanbeek ?
The text was updated successfully, but these errors were encountered: