Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve failure messages for reporting #91

Closed
jcchavezs opened this issue Nov 7, 2018 · 4 comments
Closed

Improve failure messages for reporting #91

jcchavezs opened this issue Nov 7, 2018 · 4 comments

Comments

@jcchavezs
Copy link
Contributor

jcchavezs commented Nov 7, 2018

Error log messages for reporting are meaningless https://github.com/openzipkin/zipkin-go/blob/master/reporter/http/http.go#L139 end up in

2018/11/07 13:28:24 failed the request with status code 503

in logs which might not be useful. I was thinking on

2018/11/07 13:28:24 failed the request to zipkin collector with status code 503

Any suggestion @adriancole @basvanbeek ?

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Nov 8, 2018 via email

@jcchavezs
Copy link
Contributor Author

@adriancole I actually see the value of printing both, sometimes you don't know what 172.x.x.12/v2/api/spans is whereas sometimes problem is that people uses /api/v2/spans so including both might do the trick:

2018/11/07 13:28:24 failed the request to zipkin collector (172.x.x.12/v2/api/spans) with status code 503

@basvanbeek
Copy link
Member

basvanbeek commented Dec 3, 2018

I think logging inside zipkin-go still needs a major overhaul. We shouldn't make assumptions on how stuff is being logged from within a library... that's an application concern.

Let's fix that and see what we need to do to improve reporting quality.

See #37

@jcchavezs
Copy link
Contributor Author

jcchavezs commented Dec 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants