Skip to content

Commit

Permalink
adds selfTracing property and tests (#13)
Browse files Browse the repository at this point in the history
Signed-off-by: Adrian Cole <adrian@tetrate.io>
  • Loading branch information
codefromthecrypt committed Feb 19, 2024
1 parent e78da58 commit 88717ad
Show file tree
Hide file tree
Showing 7 changed files with 43 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:
- "**/*.md"

jobs:
lint:
test:
runs-on: ubuntu-22.04
steps:
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions charts/zipkin/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
# or implied. See the License for the specific language governing permissions and limitations under
# the License.
apiVersion: v2
appVersion: 3.0.3
appVersion: 3.0.6
name: zipkin
description: A Zipkin helm chart for kubernetes
type: application
version: 0.1.2
version: 0.2.0
maintainers:
- name: openzipkin
email: zipkin-dev@googlegroups.com
2 changes: 2 additions & 0 deletions charts/zipkin/ci/default-values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
zipkin: {}
4 changes: 4 additions & 0 deletions charts/zipkin/ci/selfTracing-values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
zipkin:
selfTracing:
enabled: true
2 changes: 2 additions & 0 deletions charts/zipkin/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ spec:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
env:
- name: SELF_TRACING_ENABLED
value: "{{ .Values.zipkin.selfTracing.enabled }}"
- name: STORAGE_TYPE
value: "{{ .Values.zipkin.storage.type }}"
{{- if eq .Values.zipkin.storage.type "elasticsearch" }}
Expand Down
23 changes: 23 additions & 0 deletions charts/zipkin/templates/tests/test-connection.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
apiVersion: v1
kind: Pod
metadata:
name: "{{ include "zipkin.fullname" . }}-test-connection"
labels:
{{- include "zipkin.labels" . | nindent 4 }}
annotations:
"helm.sh/hook": test
spec:
containers:
- name: get-api-services
image: 'ghcr.io/openzipkin/alpine:3.19.1'
command: [ '/bin/sh', '-c' ]
# Get an arbitrary API endpoint using the ClusterIP and service port
args: [ 'wget -qO ---spider --header "b3: cafebabecafebabe-cafebabecafebabe-1" http://{{ include "zipkin.fullname" . }}:{{ .Values.service.port }}/api/v2/services' ]
{{- if .Values.zipkin.selfTracing.enabled }}
- name: get-trace
image: 'ghcr.io/openzipkin/alpine:3.19.1'
command: [ '/bin/sh', '-c' ]
# If self-tracing, sleep for the trace to process. Then, get it by the constant ID passed above.
args: [ 'sleep 3 && wget -qO ---spider http://{{ include "zipkin.fullname" . }}:{{ .Values.service.port }}/api/v2/trace/cafebabecafebabe' ]
{{- end }}
restartPolicy: Never
15 changes: 9 additions & 6 deletions charts/zipkin/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ podAnnotations:

podSecurityContext:
{}
# fsGroup: 2000
# fsGroup: 2000

securityContext:
# capabilities:
Expand All @@ -58,7 +58,7 @@ ingress:
annotations:
{}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
# kubernetes.io/tls-acme: "true"
# className: nginx
host: chart-example.local
path: /
Expand Down Expand Up @@ -101,11 +101,14 @@ affinity: {}
priorityClassName: ""

zipkin:
# selfTracing generates traces for HTTP paths under /api
selfTracing:
enabled: false
storage:
type: mem
# type: elasticsearch
# elasticsearch:
# hosts: hostA hostB
# index: fooIndex
# type: elasticsearch
# elasticsearch:
# hosts: hostA hostB
# index: fooIndex
extraEnv: {}
# JAVA_OPTS: "-Xms128m -Xmx512m -XX:+ExitOnOutOfMemoryError"

0 comments on commit 88717ad

Please sign in to comment.