adds selfTracing property and tests #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <adrian@tetrate.io>
added 2 commits
February 19, 2024 16:31
|
so the key here is that |
| @@ -0,0 +1,23 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
what is different about most helm charts is even if they have a 'ci' directory, they don't have a test pod. So unless I am missing something, you only test that the thing didn't crash on ct install. This file allows you to write some things without moving to a more fancy framework like https://github.com/helm-unittest/helm-unittest (not sure that one is unit tests or integration, but anyway not using it yet)
Thanks @tamalsaha for pointing it out, in case we do use it one day.
Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
merging to make it easier to backfill ES tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking at #11 I noticed there are no examples of actual integration tests. This uses self-tracing arbitrarily to show how to do it.