ci: use zipkinci for release like other projects (#8)

Signed-off-by: Adrian Cole <adrian@tetrate.io>
openzipkin · Dec 31, 2023 · 990ca7a · 990ca7a
1 parent 5a22dd0
commit 990ca7a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -16,9 +16,9 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Configure Git
-        run: |
-          git config user.name "$GITHUB_ACTOR"
-          git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
+        run: | # Allocate commits to CI, not the owner of the deploy key
+          git config user.name "zipkinci"
+          git config user.email "zipkinci+zipkin-dev@googlegroups.com"
 
       - name: Get latest zipkin version
         uses: oprypin/find-latest-tag@v1

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -7,13 +7,10 @@ name: helm_test
 
 # We don't test documentation-only commits.
 on:
-  # We run tests on non-tagged pushes to master that aren't a commit made by the release plugin
   push:
-    tags: ""
     branches: master
     paths-ignore:
       - "**/*.md"
-  # We also run tests on pull requests targeted at the master branch.
   pull_request:
     branches: master
     paths-ignore:
@@ -25,9 +22,11 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          fetch-depth: '0'  # to see origin/master
 
       - name: Configure Git
-        run: |
+        run: |  # not zipkinci as this is for testing
           git config user.name "$GITHUB_ACTOR"
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"