update readme to be more specific about browser vs nodejs support #54 #312
Conversation
|
I would also ask you to write an example in
https://github.com/openzipkin/zipkin-js-example.
The idea on this is not only that it works an examples for uses but here we
also run E2E tests against the latest zipkin version every night to make
sure we don't break examples.
Den lør. 8. des. 2018, 23:37 skrev Eric Hauser <notifications@github.com:
… ------------------------------
You can view, comment on, or merge this pull request online at:
#312
Commit Summary
- update readme to be more specific about browser vs nodejs support #54
File Changes
- *M* README.md
<https://github.com/openzipkin/zipkin-js/pull/312/files#diff-0> (30)
Patch Links:
- https://github.com/openzipkin/zipkin-js/pull/312.patch
- https://github.com/openzipkin/zipkin-js/pull/312.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#312>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC7sAnlL6BakbkFH-GLNLDsKkQgCp3yKks5u3D8rgaJpZM4ZJ2gY>
.
|
|
Not sure what you are asking for here. There already is an example in the project for the browser? |
|
So, the CI curls the address localhost:8081 and bypass the browser part: https://github.com/openzipkin/zipkin-js-example/blob/master/.circleci/config.yml#L33 <https://github.com/openzipkin/zipkin-js-example/blob/master/.circleci/config.yml#L33>.
I envision something like running the browser part in a headless chrome and then checking that trace shows up on zipkin. Please let me know if that does not make any sense.
cc/ @DanielMSchmidt
… 9. des. 2018 kl. 17:58 skrev Eric Hauser ***@***.***>:
Not sure what you are asking for here. There already is an example in the project for the browser?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#312 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7sAszIEbw7AhlUD3JqjAWqFYCUrGGBks5u3UEogaJpZM4ZJ2gY>.
|
|
Got it. That makes sense. Once #314 is merged, all the unit tests will be running under both Firefox and Chrome which will provide integration tests for running under the browser. As far as I can tell, there currently isn't a way to send local traces generated in the browser directly to a Zipkin server as the HTTP transport relies on node libraries. I'm planning on opening a separate issue to address that problem and think it would make sense to add an end to end test as part of that work. |
…n be run under the browser
|
Did a bit more digging and it seems that the first revision was inaccurate. It does appear that you can use the I found a workaround for this and will update. |
…d provide instructions for compiling with Typescript
|
@ewhauser shall we merge this? |
|
Yes, good to go |
|
@ewhauser so you have an Angular application working with zipkin-js ? i am currently working on this, but if this has been done I will stop to prevent duplication of efforts. |
|
Great!
José Carlos Chávez
Den tir. 11. des. 2018 kl. 16:11 skrev DDd <notifications@github.com>:
… @ewhauser <https://github.com/ewhauser> so you have an Angular
application working with zipkin-js ? i am currently working on this, but if
this has been done I will stop to prevent duplication of efforts.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#312 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC7sAsMOaZLr-oI25VGOFWIzAanqgDboks5u38sTgaJpZM4ZJ2gY>
.
|
|
@webmutation - Yes, I have a prototype that integrates Zipkin and Angular. I'm finishing up the README and tests but plan on making it available by the end of the week. |
|
Oh great news. Can you share the repo as is if its public. |
|
@webmutation I've made this available here: https://github.com/ewhauser/angular-tracing. Please keep in mind that it is an early prototype and there are probably dragons. Feel free to provide some feedback! |
This updates the
READMEfile to be more explicit about which parts of this project are available for node.js and the browser. This addresses #54 and is the first task in #311.