Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete zipkin-ui module #2569

Closed
codefromthecrypt opened this issue May 8, 2019 · 2 comments
Closed

Delete zipkin-ui module #2569

codefromthecrypt opened this issue May 8, 2019 · 2 comments
Assignees
Labels

Comments

@codefromthecrypt
Copy link
Member

codefromthecrypt commented May 8, 2019

When we delete the zipkin-ui module, we need to also delete any references to it. Here is a list of some of these

@codefromthecrypt
Copy link
Member Author

It turns out that we can delete this a lot sooner than we expected, solving the problem by using an archive repo instead of constantly building the same code here: https://github.com/openzipkin/zipkin-classic/

once #2603 is merged we should do the following in one PR (@zeagord claimed the honors on this)

  • move zipkin-ui/testdata to zipkin-lens
  • remove exclusions in pom.xml remove when deleting zipkin-ui #2569
  • remove recursively the zipkin-ui directory
  • remove the following from the LICENSE file
This product contains a modified part of Chosen, distributed by Harvest:

  * License: MIT
  * Homepage: https://github.com/harvesthq/chosen

This product contains a modified part of Dager-D3, distributed by Dagre:

  * License: MIT
  * Homepage: https://github.com/dagrejs/dagre-d3

@jorgheymans
Copy link
Contributor

zipkin-ui module was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants