Reverts skew "uncorrection" in index as it affects service percentages #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What we did is add an async span that runs past the critical path. When we don't do skew correction, the result is this: When we do skew correction, the result is this: While we don't know which result is correct, we should keep the historical behavior until we know what the correct result should be. So, this reverts the change. |
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
openzipkin#2229) In openzipkin#2228 my assumption was incorrect as @tacigar highlighted. This makes a test to ensure the logic stays the same for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2228 my assumption was incorrect as @tacigar highlighted. This makes
a test to ensure the logic stays the same for now.