Adds AutocompleteTags and corresponding REST api #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional storage interface `AutocompleteTags` to the `StorageComponent` and corresponding endpoints to support the UI. /api/v2/autocompleteKeys and /api/v2/autocompleteKeys?key=http.host The server accepts a parameter `zipkin.storage.autocompleteKeys` which acts as a whitelist as storing values for every tag would be expensive.
|
Sure. I think so too. |
shakuzen
approved these changes
Dec 17, 2018
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
* Adds AutocompleteTags and corresponding REST api This adds an optional storage interface `AutocompleteTags` to the `StorageComponent` and corresponding endpoints to support the UI. /api/v2/autocompleteKeys and /api/v2/autocompleteKeys?key=http.host The server accepts a parameter `zipkin.storage.autocompleteKeys` which acts as a whitelist as storing values for every tag would be expensive. * Info when not implemented and backfill tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional storage interface
AutocompleteTagsto theStorageComponentand corresponding endpoints to support the UI./api/v2/autocompleteKeysand/api/v2/autocompleteValues?key=http.hostCache control is always set on the keys, and it is set conditionally on values when there are more than 3. The "more than 3" allows for a freshly booting system to not confuse users (we do the same thing on
/api/v2/spans?serviceName=fooendpoint).The server accepts an environment variable
AUTOCOMPLETE_KEYSwhich acts as a whitelist as storing values for every tag would be
expensive.