-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from okhttp to armeria #2653
Merged
codefromthecrypt
merged 27 commits into
openzipkin:master
from
anuraaga:elasticsearch-armeria
Jul 14, 2019
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e2314d0
Migrate more
anuraaga 26eb587
Migrate more
anuraaga e476ab6
Migrate some tests.
anuraaga 2e9e1f1
Finish migrating tests
anuraaga 7b3031b
Update zipkin-server
anuraaga f0d6f72
Remove okhttp dependency
anuraaga 3e844b9
benchmarks compile
anuraaga 65c543e
Allow customizing connect timeout
anuraaga 4090c8f
Integration tests pass.
anuraaga 4a9f9de
Fix flake?
anuraaga d96d9ee
Disable HTTP/2 preface by default since elasticsearch v7 doesn't supp…
anuraaga fa39b6f
Workaround Armeria server broken when disabling HTTP/2 preface.
anuraaga f1ccb11
Missed one spot.
anuraaga b44792b
Fix ReadBuffer and do DNS round robin.
anuraaga 88cc4c3
Update README some more.
anuraaga 043b7b1
Wait for load balanced endpoints when starting.
anuraaga 9eb0412
Log bodies.
anuraaga 851d294
Copyright
anuraaga 59eef1e
Fix decorator constructor.
anuraaga bb8143c
Fix health endpoint is blocking the event loop.
anuraaga b38f760
Don't use pooled buffer for span indexing since we copy back right aw…
anuraaga 71e6e7f
Unregister endpoint group when closing.
anuraaga e4cfc4e
Work around bad interaction between recreating Storage object and Arm…
anuraaga 0b3f903
Fuzz
anuraaga c2d4b30
Small cleanup
anuraaga 76263f9
Don't reinitialize storage so much during IT.
anuraaga c1d3eac
Better toString
anuraaga File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side q: will any of the other read methods end up blocking the event loop? ex getTraces etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope they all return
AggregatedHttpResponse
so don't run on the event loop. Though I'm definitely interested in eventually migrating them to useenqueue
instead ofexecute
to be fully async :)