Fixes thread safety bug on in-memory storage regarding accept count #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Aug 24, 2019
codefromthecrypt
force-pushed
the
read-bug
branch
from
ccded4c
to
c41077f
Compare
|
so still flaking on one endpoint which isn't returning a span for the storage layer.. [
{
"traceId": "7dddc296c13a5448",
"id": "7dddc296c13a5448",
"kind": "SERVER",
"name": "post /api/v1/spans",
"timestamp": 1566632878396438,
"duration": 14240,
"localEndpoint": {
"serviceName": "zipkin-server",
"ipv4": "172.17.0.1"
},
"remoteEndpoint": {
"ipv4": "127.0.0.1",
"port": 57474
},
"annotations": [
{
"timestamp": 1566632878396451,
"value": "wr"
},
{
"timestamp": 1566632878410664,
"value": "ws"
}
],
"tags": {
"http.method": "POST",
"http.path": "/api/v1/spans"
}
}
] |
codefromthecrypt
force-pushed
the
read-bug
branch
5 times, most recently
from
ab40ad0
to
8e34a6e
Compare
added 2 commits
August 24, 2019 19:43
Before, we were using an unsafe means to increment a counter for the in-memory storage. This contributed to a test flake. This fixes the state bug and also tightens up the flakey test. The flakey test still exists, so is disabled for now.
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…penzipkin#2779) Before, we were using an unsafe means to increment a counter for the in-memory storage. This contributed to a test flake. This fixes the state bug and also tightens up the flakey test. The flakey test still exists, so is disabled for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were using an unsafe means to increment a counter for the
in-memory storage. This contributed to a test flake. This fixes the
state bug and also tightens up the flakey test.