Adds rationale for healthcheck config #2812
Conversation
As we routinely get FUD about slow startup or memory usage, this documents health check parameters in efforts to avoid them being read literally as "zipkin takes 30s to startup" See #2808
codefromthecrypt
requested review from
anuraaga and
devinsba
and removed request for
anuraaga
| # simultaneously bootstrapping. If in production, you have a 30s startup, please | ||
| # report to https://gitter.im/openzipkin/zipkin including the values of the | ||
| # /health and /info endpoints as this would be unexpected. | ||
| # | ||
| HEALTHCHECK --interval=5s --start-period=30s --timeout=5s CMD wget --quiet http://localhost:9411/health || exit 1 |
There was a problem hiding this comment.
@anuraaga FWIW with the above comments, I'm fine with the parameters. This is mainly defense, as mentioned a few different ways. Java raises antibodies for a lot of people who have a different favorite language.
I think you've recalled over the years people who don't like Java getting obsessed over image size, memory (with sometimes dodgy accounting of it), and startup time. It has been my experience that anything that can be used against us will. With the above comments, I think someone would have to be quite unprofessional to leap to the conclusion that we expect our server to startup in 30s. This was my goal here.. to reduce the amount of time lost, and potential sites over the FUD spread by folks who hate java.
|
thanks for the look rag n bas |
As we routinely get FUD about slow startup or memory usage, this
documents health check parameters in efforts to avoid them being read
literally as "zipkin takes 30s to startup"
See #2808