Republishes zipkin-builder only when on master, as a separate job #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help prevent build timeouts
| # * Use the "release" profile as that ensures the core jar ends up JRE 1.6 compatible | ||
| install: ./mvnw install -DskipTests=true -Dlicense.skip=true -Dmaven.javadoc.skip=true -B -V -Prelease | ||
| script: ./travis/publish.sh | ||
| # Credentials entered into https://travis-ci.org/github/openzipkin/${REPO}/settings are access |
There was a problem hiding this comment.
note: this is currently lying as I've not removed them from the bottom of the yaml, yet. Just yeah..
| @@ -155,11 +155,6 @@ push_docker_master() { | |||
| docker tag "${image}:master" "ghcr.io/${image}:master" | |||
| docker push "ghcr.io/${image}:master" | |||
| done | |||
|
|
|||
| echo Building zipkin-builder | |||
| docker/build_image zipkin-builder latest | |||
There was a problem hiding this comment.
this re-does the build (including downloading stuff from maven), which timed out the last master run
anuraaga
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help prevent build timeouts