Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker image for s390x and bump base java container 15.0.5_p3 #3384

Merged
merged 12 commits into from
Dec 14, 2021

Conversation

BbolroC
Copy link
Contributor

@BbolroC BbolroC commented Oct 25, 2021

This is a task in line with openzipkin/docker-java@2c9caad and openzipkin/docker-java@fbb1f11.

Summary

  • Update a version of the java base container to 15.0.5_p3
  • Add s390x to the platform option of docker build
  • Update a license of the docker_push file
  • Resolve the following docker build issue of zipkin-mysql for s390x
    ERROR 4047 (HY000) at line 15 in file: 'zipkin-schemas/mysql.sql': InnoDB refuses to write tables with ROW_FORMAT=COMPRESSED or KEY_BLOCK_SIZE.
    

@BbolroC BbolroC force-pushed the s390x-support branch 2 times, most recently from c247d25 to 50de9d1 Compare October 25, 2021 20:48
@BbolroC BbolroC changed the title Support docker image for 390x and bump base java container 15.0.5_p3 WIP: Support docker image for 390x and bump base java container 15.0.5_p3 Oct 25, 2021
@BbolroC
Copy link
Contributor Author

BbolroC commented Oct 25, 2021

I am currently struggling with local test on a amd64 machine. The following error messages appeared when I simply ran a command for docker-build like:

$ git clone https://github.com/openzipkin/zipkin.git
$ cd zipkin
$ # add '-X' option at https://github.com/openzipkin/zipkin/blob/master/build-bin/maven/maven_build#L23
$ build-bin/docker/docker_build openzipkin/zipkin:test
...
log messages
...
#17 32.97 [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.0:npm (npm lint) on project zipkin-lens: Failed to run task: 'npm run lint' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 254 (Exit value: 254) -> [Help 1]
#17 32.98 org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.0:npm (npm lint) on project zipkin-lens: Failed to run task
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.98     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.98     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.98     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.98     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.98     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.98     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.98     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.98     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.98     at java.lang.Thread.run (Thread.java:832)
#17 32.98 Caused by: org.apache.maven.plugin.MojoFailureException: Failed to run task
#17 32.98     at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:100)
#17 32.98     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.98     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.98     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.98     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.98     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.99     at java.lang.Thread.run (Thread.java:832)
#17 32.99 Caused by: com.github.eirslett.maven.plugins.frontend.lib.TaskRunnerException: 'npm run lint' failed.
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeTaskExecutor.execute (NodeTaskExecutor.java:63)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.NpmMojo.execute (NpmMojo.java:62)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:94)
#17 32.99     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.99     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.99     at java.lang.Thread.run (Thread.java:832)
#17 32.99 Caused by: com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutionException: org.apache.commons.exec.ExecuteException: Process exited with an error: 254 (Exit value: 254)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutor.execute (ProcessExecutor.java:82)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutor.executeAndRedirectOutput (ProcessExecutor.java:64)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeExecutor.executeAndRedirectOutput (NodeExecutor.java:29)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeTaskExecutor.execute (NodeTaskExecutor.java:58)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.NpmMojo.execute (NpmMojo.java:62)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:94)
#17 32.99     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.99     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.99     at java.lang.Thread.run (Thread.java:832)
#17 32.99 Caused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 254 (Exit value: 254)
#17 32.99     at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
#17 32.99     at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutor.execute (ProcessExecutor.java:74)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutor.executeAndRedirectOutput (ProcessExecutor.java:64)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeExecutor.executeAndRedirectOutput (NodeExecutor.java:29)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeTaskExecutor.execute (NodeTaskExecutor.java:58)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.NpmMojo.execute (NpmMojo.java:62)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:94)
#17 32.99     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.99     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.99     at java.lang.Thread.run (Thread.java:832)
#17 32.99 [ERROR] 
#17 32.99 [ERROR] 
#17 32.99 [ERROR] For more information about the errors and possible solutions, please read the following articles:
#17 32.99 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
#17 32.99 [ERROR] 
#17 33.00 [ERROR] After correcting the problems, you can resume the build with the command
#17 33.00 [ERROR]   mvn <args> -rf :zipkin-lens
------
executor failed running [/bin/sh -c /code/build-bin/maven/maven_build_or_unjar io.zipkin zipkin-server ${VERSION} exec &&     mv zipkin-server zipkin &&     /code/build-bin/maven/maven_build_or_unjar io.zipkin zipkin-server ${VERSION} slim &&     mv zipkin-server zipkin-slim]: exit code: 1

Could someone point me out to how to do successful local test?

@jcchavezs
Copy link
Contributor

Ping @eirslett

@BbolroC BbolroC changed the title WIP: Support docker image for 390x and bump base java container 15.0.5_p3 Support docker image for 390x and bump base java container 15.0.5_p3 Oct 28, 2021
@BbolroC
Copy link
Contributor Author

BbolroC commented Oct 28, 2021

I am currently struggling with local test on a amd64 machine. The following error messages appeared when I simply ran a command for docker-build like:

$ git clone https://github.com/openzipkin/zipkin.git
$ cd zipkin
$ # add '-X' option at https://github.com/openzipkin/zipkin/blob/master/build-bin/maven/maven_build#L23
$ build-bin/docker/docker_build openzipkin/zipkin:test
...
log messages
...
#17 32.97 [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.0:npm (npm lint) on project zipkin-lens: Failed to run task: 'npm run lint' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 254 (Exit value: 254) -> [Help 1]
#17 32.98 org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.0:npm (npm lint) on project zipkin-lens: Failed to run task
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.98     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.98     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.98     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.98     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.98     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.98     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.98     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.98     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.98     at java.lang.Thread.run (Thread.java:832)
#17 32.98 Caused by: org.apache.maven.plugin.MojoFailureException: Failed to run task
#17 32.98     at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:100)
#17 32.98     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.98     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.98     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.98     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.98     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.98     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.99     at java.lang.Thread.run (Thread.java:832)
#17 32.99 Caused by: com.github.eirslett.maven.plugins.frontend.lib.TaskRunnerException: 'npm run lint' failed.
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeTaskExecutor.execute (NodeTaskExecutor.java:63)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.NpmMojo.execute (NpmMojo.java:62)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:94)
#17 32.99     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.99     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.99     at java.lang.Thread.run (Thread.java:832)
#17 32.99 Caused by: com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutionException: org.apache.commons.exec.ExecuteException: Process exited with an error: 254 (Exit value: 254)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutor.execute (ProcessExecutor.java:82)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutor.executeAndRedirectOutput (ProcessExecutor.java:64)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeExecutor.executeAndRedirectOutput (NodeExecutor.java:29)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeTaskExecutor.execute (NodeTaskExecutor.java:58)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.NpmMojo.execute (NpmMojo.java:62)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:94)
#17 32.99     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.99     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.99     at java.lang.Thread.run (Thread.java:832)
#17 32.99 Caused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 254 (Exit value: 254)
#17 32.99     at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
#17 32.99     at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutor.execute (ProcessExecutor.java:74)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.ProcessExecutor.executeAndRedirectOutput (ProcessExecutor.java:64)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeExecutor.executeAndRedirectOutput (NodeExecutor.java:29)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.lib.NodeTaskExecutor.execute (NodeTaskExecutor.java:58)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.NpmMojo.execute (NpmMojo.java:62)
#17 32.99     at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:94)
#17 32.99     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#17 32.99     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#17 32.99     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
#17 32.99     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
#17 32.99     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1130)
#17 32.99     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:630)
#17 32.99     at java.lang.Thread.run (Thread.java:832)
#17 32.99 [ERROR] 
#17 32.99 [ERROR] 
#17 32.99 [ERROR] For more information about the errors and possible solutions, please read the following articles:
#17 32.99 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
#17 32.99 [ERROR] 
#17 33.00 [ERROR] After correcting the problems, you can resume the build with the command
#17 33.00 [ERROR]   mvn <args> -rf :zipkin-lens
------
executor failed running [/bin/sh -c /code/build-bin/maven/maven_build_or_unjar io.zipkin zipkin-server ${VERSION} exec &&     mv zipkin-server zipkin &&     /code/build-bin/maven/maven_build_or_unjar io.zipkin zipkin-server ${VERSION} slim &&     mv zipkin-server zipkin-slim]: exit code: 1

Could someone point me out to how to do successful local test?

It turns out that the following command should be run first:

$ ./mvnw -T1C -q --batch-mode -DskipTests --also-make -pl zipkin-server clean package

@BbolroC
Copy link
Contributor Author

BbolroC commented Oct 28, 2021

@llinder I would be very grateful if you could review this. Thank you very much.

@BbolroC BbolroC changed the title Support docker image for 390x and bump base java container 15.0.5_p3 Support docker image for s390x and bump base java container 15.0.5_p3 Oct 28, 2021
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it looks good to me. I don't think it has to block adding s390x support, but Java 15 is already EOL since it was a non-LTS version. We should separately try to get on the latest supported version, which currently is 17.

@jcchavezs
Copy link
Contributor

@llinder are we OK merging this now?

@jcchavezs
Copy link
Contributor

This is great stuff. I left a small nit comment, other than that I will merge it today.

@BbolroC
Copy link
Contributor Author

BbolroC commented Dec 14, 2021

@jcchavezs Please do not merge this until your last question is clearly resolved. 😉

Copy link
Contributor

@jcchavezs jcchavezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work and patience 💯

@jcchavezs jcchavezs merged commit 7e42c7a into openzipkin:master Dec 14, 2021
@BbolroC BbolroC deleted the s390x-support branch December 14, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants