-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support docker image for s390x and bump base java container 15.0.5_p3 #3384
Conversation
c247d25
to
50de9d1
Compare
I am currently struggling with local test on a
Could someone point me out to how to do successful local test? |
Ping @eirslett |
50de9d1
to
742be4b
Compare
742be4b
to
4b35faf
Compare
It turns out that the following command should be run first:
|
@llinder I would be very grateful if you could review this. Thank you very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally it looks good to me. I don't think it has to block adding s390x support, but Java 15 is already EOL since it was a non-LTS version. We should separately try to get on the latest supported version, which currently is 17.
@llinder are we OK merging this now? |
c801571
to
43ac359
Compare
43ac359
to
557d1e7
Compare
This is great stuff. I left a small nit comment, other than that I will merge it today. |
@jcchavezs Please do not merge this until your last question is clearly resolved. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good work and patience 💯
This is a task in line with openzipkin/docker-java@2c9caad and openzipkin/docker-java@fbb1f11.
Summary
15.0.5_p3
s390x
to theplatform
option ofdocker build
docker_push
filezipkin-mysql
for s390x