Add Helm CD for linting PRs and releasing charts #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm/chart-releaser-action maintains a file `index.yaml` in branch `gh-pages`, which refers to the chart tgz release files.
|
OK, it was kind of tricky to test, because:
So, what I did:
|
|
Awesome, thank you!
…On Fri, Dec 3, 2021, 14:52 Jorik Jonker ***@***.***> wrote:
OK, it was kind of tricky to test, because:
- The CD workflow needs to be in the default branch (ie, master)
- The workflow is only triggered by changes in chart/**
So, what I did:
1. I forked the repo (actually, already had a fork to create this PR)
2. merged the branch into master (so the CD action was in place)
3. changed something bogus under chart/, committing it into master
4. Observed a helm-release was cut out
5. Branched master, changed something bogus again, create a PR
6. Observed that the chart was getting linted
[image: image]
<https://user-images.githubusercontent.com/951654/144613576-2761ae9f-4700-4a25-a649-445ea83882a2.png>
[image: image]
<https://user-images.githubusercontent.com/951654/144613638-48e29c83-6bd7-4b87-9877-8144bec75197.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3398 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAQYRU5YX4NVIZUPINDUPDDTXANCNFSM5JJVI3IA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
jcchavezs
approved these changes
Dec 3, 2021
|
quick question, what would be the url to get the charts through helm? Do you mind adding a readme for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chart-releaser-action creates chart tarballs, puts them under releases, and maintains a file
index.yamlin branchgh-pages, which refers to these tgz release files.