Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chart: remove unneeded tracing service port #3399

Merged
merged 1 commit into from Dec 10, 2021

Conversation

jonkerj
Copy link
Contributor

@jonkerj jonkerj commented Dec 6, 2021

In #3378 we've accidentally added two services to expose Zipkin, instead of only one. This PR fixes that.

Signed-off-by: Jorik Jonker <jorik.jonker@eu.equinix.com>
Copy link
Member

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though we don't have a test suite to validate this chart.

@jonkerj could you confirm if this works on your side before merging?

@mrfelek
Copy link

mrfelek commented Dec 10, 2021

@jeqo Already deployed zipkin with this helm commit - it works.

@jeqo jeqo merged commit e89c86a into openzipkin:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants