Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: STORAGE_METHOD -> STORAGE_TYPE #3417

Merged
merged 16 commits into from Jan 27, 2022
Merged

fix: STORAGE_METHOD -> STORAGE_TYPE #3417

merged 16 commits into from Jan 27, 2022

Conversation

jcchavezs
Copy link
Contributor

@jcchavezs jcchavezs commented Jan 25, 2022 •
edited

@jcchavezs jcchavezs mentioned this pull request Jan 25, 2022
Merged
jonkerj
jonkerj suggested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jonkerj jonkerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the version (just increase the patch level) in Chart.yaml as well

@jonkerj
Copy link
Contributor

jonkerj commented Jan 26, 2022

I really like the way this is going. Don't forget to also update the chart version (.version).

jcchavezs
jcchavezs commented Jan 26, 2022
View reviewed changes
charts/zipkin/README.md Outdated Show resolved Hide resolved
@jcchavezs
Copy link
Contributor Author

You need to bump the version (just increase the patch level) in Chart.yaml as well

I will do a chart release after merge.

@jcchavezs jcchavezs merged commit f21e6f5 into master Jan 27, 2022
@jcchavezs jcchavezs deleted the fixes_storage_env_var_helm branch January 27, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkerj jonkerj jonkerj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcchavezs @jonkerj