Raises floor JRE version from 11 to 17 except core #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This raises the floor JRE version of libraries except core from 11 to 17. The only reason we had 17 in the past was due to Spark limitations that affected zipkin-dependencies. After this, folks can also consider getting rid of AutoValue for the record type (sadly no OpenRewrite for that ;). This change was manual except the parts about string formatting, exception coercing and multi-line literals. Those parts were done with OpenRewrite via below (reverting changes to core): ```bash $ mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.migrate.UpgradeToJava17 ``` The other non-manual step was about JOOQ, which was copy/pasting commands from the README, which worked without any issue. Signed-off-by: Adrian Cole <adrian@tetrate.io>
| + " }\n" | ||
| + " }\n" | ||
| + " }\n"); | ||
| result += (""" |
There was a problem hiding this comment.
this one is notably easier to read/edit!
| @@ -20,8 +20,7 @@ | |||
| <properties> | |||
| <main.basedir>${project.basedir}/../..</main.basedir> | |||
|
|
|||
| <!-- 3.16 is the last to compile with JDK 11 --> | |||
There was a problem hiding this comment.
no more revlock
anuraaga
approved these changes
Apr 16, 2024
...n-storage/elasticsearch/src/main/java/zipkin2/elasticsearch/internal/IndexNameFormatter.java
Outdated
Show resolved
Hide resolved
shakuzen
approved these changes
Apr 16, 2024
|
thanks for the eyes, folks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the floor JRE version of libraries except core from 11 to 17. The only reason we had 17 in the past was due to Spark limitations that affected zipkin-dependencies. After this, folks can also consider getting rid of AutoValue for the record type (sadly no OpenRewrite for that ;).
This change was manual except the parts about string formatting, exception coercing and multi-line literals. Those parts were done with OpenRewrite via below (reverting changes to core):
The other non-manual step was about JOOQ, which was copy/pasting commands from the README, which worked without any issue.