New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Trace to zipkin-common (part 1) #66
Closed
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
zipkin-common/src/main/scala/com/twitter/zipkin/adapter/QueryAdapter.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * Copyright 2012 Twitter Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.twitter.zipkin.adapter | ||
|
|
||
| import com.twitter.zipkin.query.{TraceTimeline, TimelineAnnotation} | ||
|
|
||
| trait QueryAdapter { | ||
| type timelineAnnotationType /* corresponds to com.twitter.zipkin.query.TimelineAnnotation */ | ||
| type traceTimelineType /* corresponds to com.twitter.zipkin.query.TraceTimeline */ | ||
|
|
||
| def apply(t: timelineAnnotationType): TimelineAnnotation | ||
| def apply(t: TimelineAnnotation): timelineAnnotationType | ||
|
|
||
| def apply(t: traceTimelineType): TraceTimeline | ||
| def apply(t: TraceTimeline): traceTimelineType | ||
| } |
21 changes: 21 additions & 0 deletions
21
zipkin-common/src/main/scala/com/twitter/zipkin/query/TimelineAnnotation.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /* | ||
| * Copyright 2012 Twitter Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.twitter.zipkin.query | ||
|
|
||
| import com.twitter.zipkin.common.Endpoint | ||
|
|
||
| case class TimelineAnnotation(timestamp: Long, value: String, host: Endpoint, spanId: Long, parentId: Option[Long], | ||
| serviceName: String, spanName: String) | ||
21 changes: 21 additions & 0 deletions
21
zipkin-common/src/main/scala/com/twitter/zipkin/query/TraceTimeline.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /* | ||
| * Copyright 2012 Twitter Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.twitter.zipkin.query | ||
|
|
||
| import com.twitter.zipkin.common.BinaryAnnotation | ||
|
|
||
| case class TraceTimeline(traceId: Long, rootSpanId: Long, annotations: Seq[TimelineAnnotation], | ||
| binaryAnnotations: Seq[BinaryAnnotation]) |
66 changes: 66 additions & 0 deletions
66
zipkin-scrooge/src/main/scala/com/twitter/zipkin/adapter/ThriftQueryAdapter.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Copyright 2012 Twitter Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.twitter.zipkin.adapter | ||
|
|
||
| import com.twitter.zipkin.gen | ||
| import com.twitter.zipkin.query.{TraceTimeline, TimelineAnnotation} | ||
|
|
||
| object ThriftQueryAdapter extends QueryAdapter { | ||
| type timelineAnnotationType = gen.TimelineAnnotation | ||
| type traceTimelineType = gen.TraceTimeline | ||
|
|
||
| /* TimelineAnnotation from Thrift */ | ||
| def apply(t: timelineAnnotationType): TimelineAnnotation = { | ||
| TimelineAnnotation( | ||
| t.`timestamp`, | ||
| t.`value`, | ||
| ThriftAdapter(t.`host`), | ||
| t.`spanId`, | ||
| t.`parentId`, | ||
| t.`serviceName`, | ||
| t.`spanName`) | ||
| } | ||
|
|
||
| /* TimelineAnnotation to Thrift */ | ||
| def apply(t: TimelineAnnotation): timelineAnnotationType = { | ||
| gen.TimelineAnnotation( | ||
| t.timestamp, | ||
| t.value, | ||
| ThriftAdapter(t.host), | ||
| t.spanId, | ||
| t.parentId, | ||
| t.serviceName, | ||
| t.spanName) | ||
| } | ||
|
|
||
| /* TraceTimeline from Thrift */ | ||
| def apply(t: traceTimelineType): TraceTimeline = { | ||
| TraceTimeline( | ||
| t.`traceId`, | ||
| t.`rootMostSpanId`, | ||
| t.`annotations`.map { ThriftQueryAdapter(_) }, | ||
| t.`binaryAnnotations`.map { ThriftAdapter(_) }) | ||
| } | ||
|
|
||
| /* TraceTimeline to Thrift */ | ||
| def apply(t: TraceTimeline): traceTimelineType = { | ||
| gen.TraceTimeline( | ||
| t.traceId, | ||
| t.rootSpanId, | ||
| t.annotations.map { ThriftQueryAdapter(_) }, | ||
| t.binaryAnnotations.map { ThriftAdapter(_) }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a comment here and on the TraceTimeline that explains what it is