-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS service failure should not cause a router restart #1513
Comments
Don't terminate router on DNS failure. Fixes #1513
@plorenz I found the bug related to this fix. Here are the details. The resolver test fails, and the router does not error out. But when I try to reach the service and initiate tcp accept, it causes a sig fault.
This is what is found at the line 300 in tproxy_linux.go I think the resolver is not initialized and the memory location is invalid during this lookup. I may be wrong here. But we need to initialize the resolver even though the test fails. |
Reopening based on comment from @dariuszSki |
@plorenz @scareything why couldn't we initialize the regular resolver instead of dummy? I am trying to understand the reason. |
@dariuszSki I think that's doable and makes a lot of sense. We should be able to always start the internal DNS server even if the self-test fails. I'll take another crack at fixing this issue without giving up the DNS server. |
Currently, if the DNS injection test fails, the router process will restart. The system should log messages regarding the failure, but continue if possible. This will allow connectivity to be preserved to access the system and attempt to remedy the issue. A process restart is very unlikely to change the failed state.
The text was updated successfully, but these errors were encountered: