Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raft should not initialize if db is misconfigured #1973

Closed
plorenz opened this issue Apr 23, 2024 · 3 comments
Closed

Raft should not initialize if db is misconfigured #1973

plorenz opened this issue Apr 23, 2024 · 3 comments
Assignees

Comments

@plorenz
Copy link
Member

plorenz commented Apr 23, 2024

Controller will try to initialize raft from the DB if it's configured. If it's configured but pointing to an invalid location, the controller will panic, but raft will already be initialized. The second run will then succeed. It should fail consistently, before raft is initialized.

@plorenz plorenz self-assigned this Apr 23, 2024
@Vrashabh-Sontakke
Copy link
Contributor

Vrashabh-Sontakke commented Apr 24, 2024

Hi @plorenz, I would like to work on this issue.

Please help me know whether I am on the correct path :

func (c *Controller) TryInitializeRaftFromBoltDb() error {

@plorenz
Copy link
Member Author

plorenz commented Apr 24, 2024

Hi @plorenz, I would like to work on this issue.

Please help me know whether I am on the correct path :

func (c *Controller) TryInitializeRaftFromBoltDb() error {

Hi @Vrashabh-Sontakke , apologies, I already had the fix coded when I created the issue. You were on the right path. If you're looking to contribute more, drop a post on the discourse: https://openziti.discourse.group/ . Let us know what size issues you'd like to tackle and/or what areas of interest you have and I'll do my best to find something. I appreciate your interest and effort!

@Vrashabh-Sontakke
Copy link
Contributor

Vrashabh-Sontakke commented Apr 24, 2024

@plorenz , no problem
I like to tackle issues with easy-medium level of difficulty, will surely post on discourse.

plorenz added a commit that referenced this issue Apr 24, 2024
Raft should not initialize if db is misconfigured. Fixes #1973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants